Use default ground planes in MPM demos - #7639
Conversation
There was a problem hiding this comment.
Isaac Lab Review Bot
The three MPM demos now use the shared GroundPlaneCfg defaults instead of local size and color overrides. The changed scene entries preserve their prim paths and positioning, with no concrete issue identified in the supplied patch.
- Design and architecture: The ground remains an
AssetBaseCfgwithin each existingInteractiveSceneCfg; no scene ownership or solver responsibility changes. Insnowball_smash.py, the separate hidden MPM collision slab remains explicitly sized and unchanged. - API: No public symbols, config fields, CLI arguments, or exports are changed. Existing ground prim paths and the two-way coupling demo’s
-wall_tground offset are preserved. - Implementation: The implementation consistently removes only the explicit ground-plane size and color arguments in all three demos. Surrounding collider, bath, crate, and MPM-ground configuration paths are unchanged. The intended tradeoff is that ground dimensions and appearance now follow shared defaults rather than demo-specific values.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryThis PR standardizes three MPM demos on the default Isaac Lab ground-plane configuration.
Confidence Score: 5/5The PR appears safe to merge because the changes affect ground-plane visual size and appearance without altering collision coverage or scene containment. No actionable failure remains: the ground collision is an infinite plane, all scenes fit within the former and new visual footprints, and the translated two-way coupling ground retains its existing position. Important Files Changed
Reviews (1): Last reviewed commit: "Use default ground planes in MPM demos" | Re-trigger Greptile |
|
run-ci |
Description
Use the default
GroundPlaneCfgappearance in the granular, two-way coupling, and snowball MPM demos. This removes per-demo size and color overrides and keeps the examples aligned with the standard Isaac Lab ground plane.No new dependencies.
Type of change
Release backport
developScreenshots
Not applicable; this intentionally adopts the standard ground-plane appearance.
Checklist
pre-commitchecks on all changed filesCONTRIBUTORS.md