Skip to content

fix mypy fails on mac - #4191

Merged
paul-nechifor merged 1 commit into
mainfrom
danvi/fix/mypy_fails_on_mac
Sep 17, 2026
Merged

paul-nechifor merged 1 commit into
mainfrom
danvi/fix/mypy_fails_on_mac

Conversation

@bogwi

@bogwi bogwi commented Sep 16, 2026

Copy link
Copy Markdown
Member

Fix these errs on mac os:

dimos % time uv run mypy dimos
dimos/hardware/whole_body/damiao/adapter.py:134: error: Dict entry 0 has incompatible type "str": "int"; expected "str": "str"  [dict-item]
dimos/hardware/whole_body/damiao/adapter.py:138: error: Argument 3 to "GsUsbBus" has incompatible type "**dict[str, str]"; expected "int | None"  [arg-type]
dimos/hardware/whole_body/damiao/adapter.py:138: error: Argument 3 to "GsUsbBus" has incompatible type "**dict[str, str]"; expected "int"  [arg-type]
dimos/hardware/whole_body/damiao/adapter.py:138: error: Argument 3 to "GsUsbBus" has incompatible type "**dict[str, str]"; expected "float"  [arg-type]
Found 4 errors in 1 file (checked 1121 source files)

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #4191      +/-   ##
==========================================
- Coverage   79.13%   79.12%   -0.01%     
==========================================
  Files        1471     1471              
  Lines      139520   139521       +1     
  Branches    11988    11989       +1     
==========================================
- Hits       110409   110402       -7     
- Misses      25705    25714       +9     
+ Partials     3406     3405       -1     
Components Coverage Δ
Tests 94.91% <ø> (-0.01%) ⬇️
Flag Coverage Δ
OS-ubuntu-24.04-arm 75.10% <100.00%> (-0.01%) ⬇️
OS-ubuntu-latest 75.80% <100.00%> (-0.01%) ⬇️
Py-3.10 75.58% <100.00%> (-0.01%) ⬇️
Py-3.11 75.78% <100.00%> (-0.01%) ⬇️
Py-3.12 75.78% <100.00%> (-0.01%) ⬇️
SelfHosted-Large 30.73% <0.00%> (-0.01%) ⬇️
SelfHosted-Linux 36.15% <0.00%> (-0.01%) ⬇️
SelfHosted-macOS 35.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/hardware/whole_body/damiao/adapter.py 94.44% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

No blocking code issue was established; the focused browser interaction remains unverified in this environment.

What we checked:

  • T-Rex attempted a focused browser-to-bridge Map2D test; the run was blocked because dotenv was unavailable in the recreated virtual environment. T-Rex
  • T-Rex captured a dependency synchronization attempt that stopped while building transitive PyAudio due to the host lacking portaudio.h. T-Rex
  • T-Rex authored a retry that excludes default test groups while retaining lint and browser dependencies, but it was not executed. T-Rex
  • T-Rex ran the requested verification, but its local artifact references were not uploaded. T-Rex

Summary

T-Rex validation blocked

The focused browser-to-bridge Map2D interaction test could not start because the available environment is missing dotenv. A dependency synchronization attempt also stopped because building PyAudio requires the unavailable portaudio.h system header.

No supported issue was identified in the changed code.

Reviews (1) · Last reviewed commit: "fix"

@leshy
leshy enabled auto-merge September 16, 2026 14:48
@bogwi
bogwi disabled auto-merge September 16, 2026 14:48
@leshy
leshy enabled auto-merge September 16, 2026 14:49
@leshy
leshy disabled auto-merge September 16, 2026 14:49
@bogwi
bogwi enabled auto-merge September 16, 2026 14:49
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Sep 16, 2026
@bogwi
bogwi added this pull request to the merge queue Sep 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 16, 2026
@bogwi
bogwi added this pull request to the merge queue Sep 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 16, 2026
@bogwi
bogwi added this pull request to the merge queue Sep 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 16, 2026
@paul-nechifor
paul-nechifor added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit 6676136 Sep 17, 2026
34 of 36 checks passed
@paul-nechifor
paul-nechifor deleted the danvi/fix/mypy_fails_on_mac branch September 17, 2026 00:25
@github-actions

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release/0.0.14:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/0.0.14 ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants