Skip to content

[Backport release/0.0.14] fix mypy fails on mac - #4197

Open
github-actions[bot] wants to merge 1 commit into
release/0.0.14from
backport/4191-to-release/0.0.14
Open

github-actions[bot] wants to merge 1 commit into
release/0.0.14from
backport/4191-to-release/0.0.14

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Description

Backport of #4191 to release/0.0.14.

Co-authored-by: bogwi <bogdan@dimensional.org>
(cherry picked from commit 6676136)
@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

Safe to merge: the changed adapter behavior was exercised across macOS and Linux selection paths without failures.

What we checked:

  • Reviewed the general platform validation proof and confirmed that both the before and after logs show 4/4 constructor assertions passing. T-Rex
  • Verified that the authored source damiao-can-bus-platform-validation.py was executed as part of the validation workflow. T-Rex
  • Located the remaining recommendation to restore the project virtual environment and run mypy on the adapter module. T-Rex

Summary

This change replaces dynamically expanded macOS GS USB selector arguments with explicit constructor branches. The macOS serial-number and index selection paths behave as intended, and Linux SocketCAN selection remains unchanged. Safe to merge.

Reviews (1) · Last reviewed commit: "fix mypy fails on mac (#4191)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants