Add Socket Basics security scanning - #4
Merged
Merged
Conversation
Adds the standard CI wrapper calling ynab-sast-scanner, matching the migrated setup already in place across other repos. Co-Authored-By: Marguerite Martinez <margueritem@ynab.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
These marshal specs round-trip our own objects to assert dump/load symmetry; there is no untrusted input to deserialize.
github-actions
Bot
removed
the
security: critical
grantcox
marked this pull request as ready for review
September 2, 2026 21:38
Author
|
FYI I will fix the CI issues in #5 |
sgrammargs
approved these changes
Sep 3, 2026
sgrammargs
left a comment
sgrammargs
left a comment
There was a problem hiding this comment.
I see the default branch has been updated - thank you for getting that done and being so thorough!
Since we don't expect this repository to see many PRs, I'm ok with in-line suppressions. If down the road we see more and similar ruby-unsafe-deserialization alerts, we should consider a repo-level suppression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Socket Basics (SAST) scanning to this repo, calling the shared
ynab-sast-scannerworkflow — the same setup already in place across other YNAB repos..github/workflows/socket-basics.yml:uses: ynab/ynab-sast-scanner/.github/workflows/socket-basics.yml@mainSOCKET_SECURITY_API_KEYandSAST_SUPPRESSIONS_APP_PRIVATE_KEYsecrets (both org-level, nothing per-repo needed)