Skip to content

Add Socket Basics security scanning - #3

Closed
grantcox wants to merge 1 commit into
ynab-v2from
add-socket-basics-scanning​

Hidden character warning

The head ref may contain hidden characters: "add-socket-basics-scanning\u200b"
Closed

grantcox wants to merge 1 commit into
ynab-v2from
add-socket-basics-scanning​

Conversation

@grantcox

@grantcox grantcox commented Sep 2, 2026

Copy link
Copy Markdown

Adds Socket Basics (SAST) scanning to this repo, calling the shared ynab-sast-scanner workflow — the same setup already in place across other YNAB repos.

.github/workflows/socket-basics.yml:

  • uses: ynab/ynab-sast-scanner/.github/workflows/socket-basics.yml@main
  • SOCKET_SECURITY_API_KEY and SAST_SUPPRESSIONS_APP_PRIVATE_KEY secrets (both org-level, nothing per-repo needed)

Adds the standard CI wrapper calling ynab-sast-scanner, matching the migrated
setup already in place across other repos.

Co-Authored-By: Marguerite Martinez <margueritem@ynab.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Socket SAST-GENERIC

Summary

🔴 Critical: 8 | 🟠 High: 0 | 🟡 Medium: 0 | ⚪ Low: 0

Details

spec/recurly_v2/adjustment_spec.rb (🔴 Critical: 2)

🔴 ruby-unsafe-deserialization: CRITICAL

spec/recurly_v2/adjustment_spec.rb:118

        adjustment_from_dump = Marshal.load(Marshal.dump(adjustment))

spec/recurly_v2/adjustment_spec.rb:127

        adjustment_from_dump = Marshal.load(Marshal.dump(adjustment))
spec/recurly_v2/billing_info_spec.rb (🔴 Critical: 2)

🔴 ruby-unsafe-deserialization: CRITICAL

spec/recurly_v2/billing_info_spec.rb:230

      billing_info_from_dump = Marshal.load(Marshal.dump(billing_info))

spec/recurly_v2/billing_info_spec.rb:240

      billing_info_from_dump = Marshal.load(Marshal.dump(billing_info))
spec/recurly_v2/credit_payment_spec.rb (🔴 Critical: 2)

🔴 ruby-unsafe-deserialization: CRITICAL

spec/recurly_v2/credit_payment_spec.rb:36

      credit_payment_from_dump = Marshal.load(Marshal.dump(credit_payment))

spec/recurly_v2/credit_payment_spec.rb:44

      credit_payment_from_dump = Marshal.load(Marshal.dump(credit_payment))
spec/recurly_v2/transaction_spec.rb (🔴 Critical: 2)

🔴 ruby-unsafe-deserialization: CRITICAL

spec/recurly_v2/transaction_spec.rb:63

      transaction_from_dump = Marshal.load(Marshal.dump(transaction))

spec/recurly_v2/transaction_spec.rb:71

      transaction_from_dump = Marshal.load(Marshal.dump(transaction))

@github-actions github-actions Bot added the security: critical Critical security vulnerabilities label Sep 2, 2026
@grantcox

grantcox commented Sep 2, 2026

Copy link
Copy Markdown
Author

Superseded by #4 — this branch name contained a stray zero-width space (U+200B), which is what triggered GitHub's hidden-character warning. Recreated from a cleanly named branch.

@grantcox grantcox closed this Sep 2, 2026
@grantcox
grantcox deleted the add-socket-basics-scanning​ branch September 2, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security: critical Critical security vulnerabilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant