Update Socket Basics job call path - #2
sgrammargs wants to merge 2 commits into
Conversation
Points the CI workflow at ynab-sast-scanner instead of shared-actions, adds the new App-token secret, and removes the legacy shared-actions caller comment. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Per Grant's review feedback, matching evergreen#30007. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
grantcox
left a comment
grantcox
left a comment
There was a problem hiding this comment.
Build failures are unrelated. I'll work on a fix for those - we really should have our CI steps working on this one, even if we very rarely (never?) make any changes to it
grantcox
left a comment
grantcox
left a comment
There was a problem hiding this comment.
Actually, this won't work. The merge target of this PR is the repo's primary branch (v3-2021-02-25), which has been inherited from the upstream's primary branch.
But we don't use that - we use our custom ynab-v2 branch only. And that branch is not based upon v3-2021-02-25 at all - presumably there is some common branch from way back (many years ago), but that's not relevant here. Changes made to the v3... branch will not be visible in the tree used by ynab-v2.
So, this PR needs to be based directly on ynab-v2. We can't just change the target here in Github, because this PR's tip does have all the v3... history in it.
This issue also affected the prior "add Socket Basics" workflow PRs too - those haven't been running on our actual ynab-v2 branch (or PRs based off that, although there have been zero of those).
|
Here is a replacement PR: #4 And, I have asked Brady to change our fork's default branch to |
2 participants
Migrates this repo's Socket Basics CI scan to the new public/private split — a public repo for the scanning mechanism, a private repo for configuration specs.
Changes to
.github/workflows/socket-basics.yml:uses:now points toynab/ynab-sast-scanner/.github/workflows/socket-basics.yml@mainSAST_SUPPRESSIONS_APP_PRIVATE_KEYsecret