Preserve GR00T dependency pins during rollout - #7666
Merged
Conversation
jaybdub
requested review from
AntoineRichard,
StafaH,
kellyguo11 and
ooctipus
as code owners
September 9, 2026 03:09
Contributor
The PR should not merge until the documented workflow preserves the GR00T pins across the intervening dataset-conversion commands. Findings
|
Contributor
There was a problem hiding this comment.
Isaac Lab Review Bot
The documented GR00T dependency pins and uv run --no-sync rollout command address the reported compatibility failures, but the workflow still includes plain uv run conversion commands that can overwrite those pins before rollout.
- Design and architecture: Pinning GR00T N1.5’s compatible dependency versions and preventing an Isaac Lab workspace sync during rollout fits the documented shared-environment workflow. However, that preservation strategy must cover every subsequent Isaac Lab-root command that can synchronize the same environment.
- API: No source-level public API changes are introduced. The user-facing CLI contract changes only by adding
--no-syncto the documented rollout invocation; the rollout script’s arguments remain unchanged. - Implementation: The conversion commands at lines 687 and 695 still use plain
uv runafter the pins are installed. According to the newly added warning, those commands can synchronize the Isaac Lab workspace and replace GR00T’s versions, while the later rollout’s--no-syncmerely preserves the already-modified environment. Apply--no-syncto those post-install conversion commands or install the compatibility pins after the final synchronizing command.
Minor fixes needed. Posted 1 actionable finding inline.
Automated review; human maintainers own approval decisions.
jaybdub
force-pushed
the
nvbug/6682951
branch
from
September 9, 2026 19:50
3c4ab98 to
7545725
Compare
jaybdub
requested review from
ClemensSchwarke,
Toni-SM,
aserifi,
david-cao-mueller,
fatimaanes,
frlai,
hougantc-nvda,
huidongc,
hujc7,
matthewtrepte,
myurasov-nv,
pbarejko,
peterd-NV,
r-schmitt,
rilei-nvidia,
rubengrandia and
rwiltz
as code owners
September 9, 2026 19:50
kellyguo11
approved these changes
Sep 9, 2026
Contributor
|
run-ci |
Contributor
|
run-ci |
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Contributor
|
Backported to |
isaaclab-bot Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
# Description Documents GR00T N1.5's compatible NumPy, PyArrow, Numpydantic, and Pydantic pins and launches dataset conversion and rollout with `uv run --no-sync`. This prevents the Isaac Lab workspace sync from replacing GR00T's versions before policy import. Tracks NVBug 6682951. ## Type of change - Bug fix - Documentation update ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` ## Validation - Reproduced both reported failures inside headless Isaac Sim 6.0.1: PyArrow `AttributeError: _ARRAY_API not found` and Numpydantic/Pydantic `InvalidSchemaError`. - Verified the actual Isaac Lab GR00T policy module imports with the documented pins and `uv run --no-sync`. - Verified the dataset conversion CLI starts with the same pinned environment and `--no-sync`. - `uv run --isolated --extra test -- make -C docs current-docs` - `uv run isaaclab -f` ## Screenshots Not applicable. ## Checklist - [x] I have read and understood the contribution guidelines. - [x] I have run the pre-commit checks. - [x] I have made the corresponding documentation change. - [x] My changes generate no new warnings. - [x] I have run a fail-before/pass-after simulator regression check. - [x] Changelog fragment is not applicable to this docs-only change. - [x] The contributor already appears in repository revision history. --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com> (cherry picked from commit 03ef2c8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents GR00T N1.5's compatible NumPy, PyArrow, Numpydantic, and Pydantic pins and launches dataset conversion and rollout with
uv run --no-sync. This prevents the Isaac Lab workspace sync from replacing GR00T's versions before policy import.Tracks NVBug 6682951.
Type of change
Release backport
developValidation
AttributeError: _ARRAY_API not foundand Numpydantic/PydanticInvalidSchemaError.uv run --no-sync.--no-sync.uv run --isolated --extra test -- make -C docs current-docsuv run isaaclab -fScreenshots
Not applicable.
Checklist