Skip to content

Preserve GR00T dependency pins during rollout - #7666

Merged
kellyguo11 merged 4 commits into
isaac-sim:developfrom
jaybdub:nvbug/6682951
Sep 9, 2026
Merged

Preserve GR00T dependency pins during rollout#7666
kellyguo11 merged 4 commits into
isaac-sim:developfrom
jaybdub:nvbug/6682951

Conversation

@jaybdub

@jaybdub jaybdub commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Documents GR00T N1.5's compatible NumPy, PyArrow, Numpydantic, and Pydantic pins and launches dataset conversion and rollout with uv run --no-sync. This prevents the Isaac Lab workspace sync from replacing GR00T's versions before policy import.

Tracks NVBug 6682951.

Type of change

  • Bug fix
  • Documentation update

Release backport

  • Backport this pull request to the active release branch after it merges into develop

Validation

  • Reproduced both reported failures inside headless Isaac Sim 6.0.1: PyArrow AttributeError: _ARRAY_API not found and Numpydantic/Pydantic InvalidSchemaError.
  • Verified the actual Isaac Lab GR00T policy module imports with the documented pins and uv run --no-sync.
  • Verified the dataset conversion CLI starts with the same pinned environment and --no-sync.
  • uv run --isolated --extra test -- make -C docs current-docs
  • uv run isaaclab -f

Screenshots

Not applicable.

Checklist

  • I have read and understood the contribution guidelines.
  • I have run the pre-commit checks.
  • I have made the corresponding documentation change.
  • My changes generate no new warnings.
  • I have run a fail-before/pass-after simulator regression check.
  • Changelog fragment is not applicable to this docs-only change.
  • The contributor already appears in repository revision history.

@jaybdub
jaybdub requested a review from a team September 9, 2026 03:09
@github-actions github-actions Bot added bug Something isn't working documentation Improvements or additions to documentation labels Sep 9, 2026
@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

The PR should not merge until the documented workflow preserves the GR00T pins across the intervening dataset-conversion commands.

Findings

  1. P1 Later Sync Replaces Pins

Summary

  • Pins compatible NumPy, PyArrow, Numpydantic, and Pydantic versions.
  • Explains the failures caused by replacing those versions.
  • Launches rollout with uv run --no-sync.
  • Still contains intervening synchronizing commands that can replace the pins before rollout.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Install GR00T-compatible pins] --> B[Dataset conversion via regular uv run]
  B --> C[Isaac Lab workspace synchronization]
  C --> D[GR00T pins replaced by workspace versions]
  D --> E[Rollout via uv run --no-sync]
  E --> F[Already-replaced versions are preserved]
  F --> G[Policy import can still fail]
Loading

Comment thread docs/source/overview/imitation-learning/humanoids_imitation.rst Outdated

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The documented GR00T dependency pins and uv run --no-sync rollout command address the reported compatibility failures, but the workflow still includes plain uv run conversion commands that can overwrite those pins before rollout.

  • Design and architecture: Pinning GR00T N1.5’s compatible dependency versions and preventing an Isaac Lab workspace sync during rollout fits the documented shared-environment workflow. However, that preservation strategy must cover every subsequent Isaac Lab-root command that can synchronize the same environment.
  • API: No source-level public API changes are introduced. The user-facing CLI contract changes only by adding --no-sync to the documented rollout invocation; the rollout script’s arguments remain unchanged.
  • Implementation: The conversion commands at lines 687 and 695 still use plain uv run after the pins are installed. According to the newly added warning, those commands can synchronize the Isaac Lab workspace and replace GR00T’s versions, while the later rollout’s --no-sync merely preserves the already-modified environment. Apply --no-sync to those post-install conversion commands or install the compatibility pins after the final synchronizing command.

Minor fixes needed. Posted 1 actionable finding inline.

Automated review; human maintainers own approval decisions.

Comment thread docs/source/overview/imitation-learning/humanoids_imitation.rst Outdated
@jaybdub
jaybdub requested a review from marcodiiga as a code owner September 9, 2026 19:50
@jaybdub
jaybdub changed the base branch from release/3.0.0 to develop September 9, 2026 19:51
@github-actions github-actions Bot added asset New asset feature or request isaac-sim Related to Isaac Sim team isaac-mimic Related to Isaac Mimic team infrastructure labels Sep 9, 2026
@kellyguo11

Copy link
Copy Markdown
Contributor

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 9, 2026
@kellyguo11

Copy link
Copy Markdown
Contributor

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 9, 2026
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
@kellyguo11
kellyguo11 merged commit 03ef2c8 into isaac-sim:develop Sep 9, 2026
22 checks passed
@isaaclab-bot

isaaclab-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Backported to release/3.0.0 as bee8c70.

isaaclab-bot Bot pushed a commit that referenced this pull request Sep 9, 2026
# Description

Documents GR00T N1.5's compatible NumPy, PyArrow, Numpydantic, and
Pydantic pins and launches dataset conversion and rollout with `uv run
--no-sync`. This prevents the Isaac Lab workspace sync from replacing
GR00T's versions before policy import.

Tracks NVBug 6682951.

## Type of change

- Bug fix
- Documentation update

## Release backport

- [x] <!-- backport-active-release --> Backport this pull request to the
active release branch after it merges into `develop`

## Validation

- Reproduced both reported failures inside headless Isaac Sim 6.0.1:
PyArrow `AttributeError: _ARRAY_API not found` and Numpydantic/Pydantic
`InvalidSchemaError`.
- Verified the actual Isaac Lab GR00T policy module imports with the
documented pins and `uv run --no-sync`.
- Verified the dataset conversion CLI starts with the same pinned
environment and `--no-sync`.
- `uv run --isolated --extra test -- make -C docs current-docs`
- `uv run isaaclab -f`

## Screenshots

Not applicable.

## Checklist

- [x] I have read and understood the contribution guidelines.
- [x] I have run the pre-commit checks.
- [x] I have made the corresponding documentation change.
- [x] My changes generate no new warnings.
- [x] I have run a fail-before/pass-after simulator regression check.
- [x] Changelog fragment is not applicable to this docs-only change.
- [x] The contributor already appears in repository revision history.

---------

Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Co-authored-by: Kelly Guo <kellyg@nvidia.com>

(cherry picked from commit 03ef2c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

asset New asset feature or request bug Something isn't working documentation Improvements or additions to documentation infrastructure isaac-mimic Related to Isaac Mimic team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants