Enable G1 SDG hand contact sensors - #7663
Open
jaybdub wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR locally enables contact reporting for the G1 locomanipulation SDG robot spawn and adds the required isaaclab_mimic changelog fragment. The change directly addresses initialization of the inherited hand contact sensors without broadening the patch.
- Design and architecture: The fix is scoped to G1LocomanipulationSDGEnvCfg.post_init, where this configuration defines its own initialization behavior. This is a small, targeted correction rather than a broader change to shared robot or environment configuration.
- API: No public symbols or constructor signatures change. The effective spawn configuration now enables contact sensors for this environment, which is the intended behavioral correction, and the user-visible fix is documented in a package changelog fragment.
- Implementation: The new assignment sets self.scene.robot.spawn.activate_contact_sensors before the remaining simulation, controller, and termination configuration. Nothing later in the shown initialization path overwrites the flag, so it remains enabled when the configured robot is spawned.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Contributor
jaybdub
force-pushed
the
nvbug/6682681
branch
from
September 9, 2026 19:50
de80ea4 to
45fcbcc
Compare
jaybdub
requested review from
AntoineRichard,
ClemensSchwarke,
StafaH,
Toni-SM,
aserifi,
david-cao-mueller,
fatimaanes,
frlai,
hougantc-nvda,
huidongc,
hujc7,
marcodiiga,
matthewtrepte,
myurasov-nv,
ooctipus,
pbarejko,
r-schmitt,
rilei-nvidia,
rubengrandia and
rwiltz
as code owners
September 9, 2026 19:50
Contributor
|
@jaybdub do we want to cherry pick this to release/3.0.0? |
rwiltz
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables contact reporting on the G1 robot spawn configuration used by the locomanipulation SDG environment. This allows the left and right hand contact sensors to resolve their bodies during environment initialization.
Tracks NVBug 6682681.
Type of change
Validation
ContactSensorinitialization failure fromrelease/3.0.0in headless Isaac Sim 6.0.1.uv run --no-sync python tools/changelog/cli.py check developuv run isaaclab -fScreenshots
Not applicable.
Checklist
isaaclab_mimicchangelog fragment.