Skip to content

Enable G1 SDG hand contact sensors - #7663

Open
jaybdub wants to merge 1 commit into
isaac-sim:developfrom
jaybdub:nvbug/6682681
Open

Enable G1 SDG hand contact sensors#7663
jaybdub wants to merge 1 commit into
isaac-sim:developfrom
jaybdub:nvbug/6682681

Conversation

@jaybdub

@jaybdub jaybdub commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Description

Enables contact reporting on the G1 robot spawn configuration used by the locomanipulation SDG environment. This allows the left and right hand contact sensors to resolve their bodies during environment initialization.

Tracks NVBug 6682681.

Type of change

  • Bug fix

Validation

  • Reproduced the reported ContactSensor initialization failure from release/3.0.0 in headless Isaac Sim 6.0.1.
  • Verified the fixed environment initializes both hand sensors and returns force tensors.
  • uv run --no-sync python tools/changelog/cli.py check develop
  • uv run isaaclab -f

Screenshots

Not applicable.

Checklist

  • I have read and understood the contribution guidelines.
  • I have run the pre-commit checks.
  • No documentation change is required for this configuration fix.
  • My changes generate no new warnings.
  • I have run a fail-before/pass-after simulator regression check.
  • I have added an isaaclab_mimic changelog fragment.
  • The contributor already appears in repository revision history.

@jaybdub
jaybdub requested a review from a team September 9, 2026 03:09
@github-actions github-actions Bot added bug Something isn't working isaac-mimic Related to Isaac Mimic team labels Sep 9, 2026

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The PR locally enables contact reporting for the G1 locomanipulation SDG robot spawn and adds the required isaaclab_mimic changelog fragment. The change directly addresses initialization of the inherited hand contact sensors without broadening the patch.

  • Design and architecture: The fix is scoped to G1LocomanipulationSDGEnvCfg.post_init, where this configuration defines its own initialization behavior. This is a small, targeted correction rather than a broader change to shared robot or environment configuration.
  • API: No public symbols or constructor signatures change. The effective spawn configuration now enables contact sensors for this environment, which is the intended behavioral correction, and the user-visible fix is documented in a package changelog fragment.
  • Implementation: The new assignment sets self.scene.robot.spawn.activate_contact_sensors before the remaining simulation, controller, and termination configuration. Nothing later in the shown initialization path overwrites the flag, so it remains enabled when the configured robot is spawned.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the configuration change uses the established mechanism required by the inherited hand contact sensors.

Summary

  • Enables contact reporting on the G1 robot spawn configuration.
  • Adds an isaaclab_mimic changelog fragment documenting the fix.

@github-actions github-actions Bot added documentation Improvements or additions to documentation isaac-sim Related to Isaac Sim team infrastructure labels Sep 9, 2026
@rwiltz

rwiltz commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@jaybdub do we want to cherry pick this to release/3.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation infrastructure isaac-mimic Related to Isaac Mimic team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants