Add optional support for ovrtx-0.5 - #7351
Conversation
Greptile SummaryThe PR adds compatibility for the OVRTX 0.5 render-variable key format while retaining source-name keys for OVRTX 0.4.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Import OVRTX compatibility module] --> B[Read installed OVRTX version]
B --> C{Version 0.5 or newer?}
C -->|No| D[Use source-name frame keys]
C -->|Yes| E[Use authored RenderVar prim paths]
D --> F[Renderer reads frame.render_vars]
E --> F
F --> G[Populate camera and segmentation outputs]
Reviews (2): Last reviewed commit: "Add optional support for ovrtx-0.5" | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
Reviewed the import-time OVRTX version compatibility decision and traced render-var key resolution through USD authoring, frame consumption, and segmentation metadata paths. The patch consistently switches OVRTX 0.4 source-name keys to OVRTX 0.5+ authored prim-path keys while preserving the pinned 0.4 behavior.
- Design and architecture: Compatibility is isolated at the OVRTX boundary, with frame keys derived from the same render-var definitions used for USD authoring. Resolving immutable keys once at import is consistent with the assumption that the installed OVRTX distribution does not change during the process.
- API: Existing render-var configuration signatures and tuple contracts remain unchanged. The added compatibility and source-to-prim-path helpers are additive, the renderer parameter rename affects only a private method, and the user-visible compatibility change has an isaaclab_ov changelog fragment.
- Implementation: Renderer lookups for color, depth, albedo, normals, motion vectors, segmentation outputs, and segmentation maps consistently use the resolved key form. Tests cover version classification, nontrivial authored paths, mapping completeness and immutability, and installed-key frame selection. Residual compatibility depends on frame.render_vars supporting mapping-style get(), and installs without readable distribution metadata intentionally retain OVRTX 0.4 key behavior.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
|
run-ci |
951b0a7 to
d0acc66
Compare
|
run-ci |
d0acc66 to
c0a632e
Compare
|
@greptile review |
|
run-ci |
|
run-ci |
|
run-ci |
Description
Adds optional compatibility with the OVRTX 0.5 render-variable API while preserving OVRTX 0.4 behavior.
OVRTX 0.4 keys
frame.render_varsby source name, while OVRTX 0.5 uses the authored RenderVar prim path. This PR:ovrtx_usd.py.This PR adds render-var API compatibility only. It does not bump OVRTX, OVStage, or OVPhysX dependencies, enable the OVStage rendering path, or rebaseline OVRTX 0.5 golden images.
Type of change
Release backport
developChecklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there