Fix optional attribute indices in msh2obj output - #3595
Open
HaokaiDing wants to merge 1 commit into
Open
HaokaiDing wants to merge 1 commit into
HaokaiDing wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3594.
Legacy MSH files may omit normals and/or texture coordinates, but
msh_to_objalways writes faces asv/vt/vn. The resulting OBJ then references attribute records that do not exist.Select the face format from the attribute arrays present in the MSH:
vv/vtv//vnv/vt/vnThe new parameterized test writes real tetrahedral MSH files for all four combinations, checks face syntax and attribute counts, and loads both the MSH and OBJ through MuJoCo. The existing full-attribute mesh comparison is retained. Explicit face assertions are necessary because MuJoCo's OBJ loader tolerates missing attribute arrays.
Validation:
git diff --checkpass.Local tests used the checkout converter/test file with the real MuJoCo 3.13.0 macOS wheel for model loading, Python 3.13.15 and NumPy 2.5.3. The loaded converter path was checked to point at the checkout. The wheel uses float64; the current C++ source tree, full binding suite and
mjUSESINGLEbuild were not built or run locally. New assertions concern OBJ strings and integer counts.