Fix inconsistent axis labels in solimp documentation figures - #3548
Open
ManoharPaturi wants to merge 2 commits into
Open
ManoharPaturi wants to merge 2 commits into
ManoharPaturi wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Body:
Fixes #3545
What does this PR do?
The
$d_0$ and $d_{\text{width}}$ (since 83e7095), but the
solimptext inmodeling.rstdefines the impedance parameters asd(r)plot grid(
doc/images/modeling/impedance.png/impedance_dark.png) still labelsthe vertical axis
dmax/dmin— names that appear nowhere in the docs.This regenerates both figures (light and dark) with the y-axis annotation$d_0$ (bottom level, $d_{\text{width}}$ (top level,
renamed to
r = 0) andr = ±width), matching the text. Everything else is reproduced faithfully:same 3×3 panel grid (
pow1/2/6 ×mid0.1/0.5/0.9), same curve shapesfrom the documented impedance interpolation, same dimensions (1580×1052),
same light/dark palettes, and the original labeling scheme (y labels only on
the top-left panel, x labels only on the bottom-left panel).
The curves use the impedance function as documented in the Modeling chapter:
d(r) = d₀ + (d_width − d₀) · S(|r|/width)with the power/midpoint splineS(x) = 0.5·(x/y)^pforx ≤ yand1 − 0.5·((1−x)/(1−y))^potherwise.How was it generated?
There is no figure-generation script in the repo, so the figures were
regenerated with the standalone matplotlib script below (happy to commit it
somewhere appropriate if you'd like to keep it):
generator script