Conversation
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cc/feat/openyam-teach-data-collection #3931 +/- ##
=========================================================================
+ Coverage 79.68% 79.74% +0.06%
=========================================================================
Files 1521 1530 +9
Lines 143383 144292 +909
Branches 12246 12319 +73
=========================================================================
+ Hits 114249 115060 +811
- Misses 25788 25866 +78
- Partials 3346 3366 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
from
September 4, 2026 03:24
953eaf3 to
11dd36d
Compare
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
from
September 4, 2026 19:33
11dd36d to
b33e734
Compare
1 task
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
from
September 8, 2026 23:42
711abf3 to
dab8c6f
Compare
TomCC7
marked this pull request as ready for review
September 8, 2026 23:52
TomCC7
requested review from
Dreamsorcerer,
aclauer,
bogwi,
jeff-hykin,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
September 8, 2026 23:52
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
from
September 8, 2026 23:55
dab8c6f to
89ed1c5
Compare
Contributor
Not safe to merge: an active but unresponsive coordinator can be bypassed, allowing a competing robot-control stack to start. Findings
|
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
from
September 10, 2026 20:48
89ed1c5 to
a78679d
Compare
This was referenced Sep 11, 2026
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
from
September 15, 2026 05:51
6a79214 to
eec675e
Compare
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
from
September 17, 2026 23:36
eec675e to
1f3e8eb
Compare
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
2 times, most recently
from
September 18, 2026 00:39
2a46210 to
d186d3a
Compare
TomCC7
force-pushed
the
cc/feat/robot-learning-sdk
branch
from
September 18, 2026 01:50
d186d3a to
6d708af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
Solution
Add
dimos imitation collectandrolloutas attached Textual controls.Discover controllers through
Dimos.connect().find_module_by_spec(...), using the Specs already defined in feat(imitation): add native OpenYAM collection #3854 and refactor(imitation): isolate LeRobot policy runtime #3315.Keep launch, module configuration, and lifecycle in
dimos run; remove workflow catalogs and dedicated robot flags.Add directory-based
prepareandinspect, reading theschema.jsoncontract from feat(imitation): add native OpenYAM collection #3854.Delegate visualization to isolated
lerobot-dataset-viz; use a stable path-derived dataset identity so Rerun does not reuse another recording's Blueprint. Do not hardcode camera views or joint labels.Pass training arguments directly to isolated
lerobot-train.Document external Blueprint entry points and the unchanged Python recorder path for G1.
Keep dual-arm composition in feat(imitation): add profile-driven dual-arm collection #3942 and the existing single-camera LeRobot backend unchanged.
Assert viewer help/errors after stripping ANSI styles with Click; test plain and forced-color output.
API shape
get_status(),command(event). Space starts/saves, D discards, Q detaches.preflight_rollout(),start_rollout(),stop_rollout(),rollout_status(). Space explicitly starts/stops; Q detaches.--moduleselector.dimos stopseparately; neither panel is a deadman switch.vendor-robotcan publishcollect = "vendor_robot.collection:collect"under[project.entry-points."dimos.blueprints"], then run asdimos run vendor-robot.collect. No imitation registry entry is needed.How to Test
With single-arm teaching hardware configured:
dimos --can-port follower_l run openyam-teach-collection --daemon --recorder.recording recordings/session-001 --episodes.task "pick up the cube" dimos imitation collectAfter saving episodes:
Launch
openyam-lerobot-rolloutwith a compatible checkpoint, then attachdimos imitation rollout.In the previous cleanup: 19 CLI/TUI/conversion-process tests and 6 registry checks passed; scoped mypy and commit hooks passed.
Current review cleanup: all 28 CLI tests pass in the final focused suite; the visualization identity fix now lives in this layer rather than dual-arm integration. No interactive viewer retest was performed.
Coverage includes external Spec discovery, rejected ambiguity, detach behavior, headless collection controls, and direct training argument forwarding.
Physical collection, rollout, and shutdown remain hardware release checks.
CI repair: all 34 CLI tests and the documentation-branding check passed under forced color. No changes to the viewer launch contract.
AI assistance
Checklist