Skip to content

Add hand_eye_calibration_sim to the config list - #971

Open
fdavulcu wants to merge 1 commit into
mainfrom
feat/list-hand-eye-calibration-sim
Open

fdavulcu wants to merge 1 commit into
mainfrom
feat/list-hand-eye-calibration-sim

Conversation

@fdavulcu

Copy link
Copy Markdown

[written by AI]

hand_eye_calibration_sim was hidden from moveit_pro run --list and moveit_pro configure until the hand-eye calibration Objectives shipped. They have, and the camera calibration guide now walks through this config, so the MOVEIT_PRO_IGNORE marker goes. The README sentence that described the marker goes with it.

@fdavulcu fdavulcu added this to the 10.2.0 milestone Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: ca64ea31-6463-4dd2-ae5b-f72e0297e36c

📥 Commits

Reviewing files that changed from the base of the PR and between 0da511d and 0fd57b8.

📒 Files selected for processing (2)
  • src/hand_eye_calibration_sim/MOVEIT_PRO_IGNORE
  • src/hand_eye_calibration_sim/README.md
💤 Files with no reviewable changes (1)
  • src/hand_eye_calibration_sim/MOVEIT_PRO_IGNORE
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/hand_eye_calibration_sim/README.md

Included review availability: 6 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated the hand-eye calibration simulator documentation by removing an outdated statement about application configuration.

Walkthrough

The package README no longer documents that MOVEIT_PRO_IGNORE keeps the package out of the app configuration list.

Changes

README documentation

Layer / File(s) Summary
Remove configuration statement
src/hand_eye_calibration_sim/README.md
Removes the statement about MOVEIT_PRO_IGNORE and package configuration.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 0fd57

The package is available to the launcher as intended, and the README no longer describes the removed exclusion behavior.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly matches the changes. It explains removal of the MOVEIT_PRO_IGNORE marker and the related README sentence because the hand-eye calibration Objectives have shipped.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Human Review Check ✅ Passed The PR is low-risk under this check. The authoritative diff changes only two files in src/hand_eye_calibration_sim: it deletes the empty MOVEIT_PRO_IGNORE marker and removes one README sentence th…

Comment @coderabbitai help to get the list of available commands.

@fdavulcu
fdavulcu marked this pull request as ready for review September 17, 2026 09:46
@fdavulcu
fdavulcu enabled auto-merge September 17, 2026 09:49
@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

1 similar comment
@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

The calibration Objectives it was waiting for have shipped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@JWhitleyWork
JWhitleyWork force-pushed the feat/list-hand-eye-calibration-sim branch from 0da511d to 0fd57b8 Compare September 17, 2026 16:15
@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant