Skip to content

docs(skills): expand aeo_crosslink_audit scope to include Factories - #779

Merged
rachaelrenk merged 3 commits into
mainfrom
docs/aeo-crosslink-audit-add-factories
Sep 22, 2026
Merged

rachaelrenk merged 3 commits into
mainfrom
docs/aeo-crosslink-audit-add-factories

Conversation

@rachaelrenk

@rachaelrenk rachaelrenk commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Promotes Factories to a fourth pilot topic for the aeo_crosslink_audit scheduled agent, alongside Agents, Cloud agents, and Orchestration.

Why

The run log (.agents/logs/aeo_crosslink_audit_runs.md) shows Factories and software factory pages appearing in four of the last five runs (2026-08-24 PR #612, 2026-09-07 PR #691, 2026-09-14 PR #741, 2026-09-21 PR #775), including edits to Factories pages themselves such as factories/index.mdx, factories/factory-agents.mdx, and factories/factory-dashboard.mdx, as a side effect of auditing in-scope pages. Factories was never a scoped topic in its own right, so those edits happened opportunistically rather than from a systematic scan of Factories content on equal footing with the other three topics. Warp Factories is now the primary product focus, so this closes that gap by making Factories a first-class pilot topic instead of an incidental byproduct.

Changes

.agents/skills/aeo_crosslink_audit/SKILL.md

  • Added Factories under src/content/docs/factories/ to the Scope section, audited as both source pages and valid link targets, on the same footing as the other three topics
  • Extended Peec and Google Search Console signal collection to include factory-related prompts and queries
  • Updated the standing PR title format from "docs: add AEO cross-links for agents and orchestration" to "docs: add AEO cross-links for agents, orchestration, and factories"
  • Updated the AEO brief Goal line and the no-change report's Topic area line to name factories

Documentation risk

Risk: low
Rationale: Skill-infra-only change to aeo_crosslink_audit/SKILL.md; no src/content/docs/ pages touched, no new product claims.
Docs override: none

Unverified claims

  • None. Skill-configuration change only; no VERIFY markers.

Co-Authored-By: Warp agent@warp.dev

The run log shows Factories/software factory pages surfacing as link
targets in 4 of the last 5 runs even though Factories was never a
pilot topic (Agents, Cloud agents, Orchestration only). Warp Factories
is now the primary product focus, so this promotes Factories to a
fourth pilot topic:

- Add Factories (src/content/docs/factories/) to ## Scope, audited as
  both source pages and link targets
- Extend Peec and GSC signal collection to include factory-related
  prompts/queries
- Update the PR title format and AEO brief goal to name factories
- Update the no-change report's Topic area line

Co-Authored-By: Warp <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Sep 21, 2026
@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 22, 2026 4:15pm UTC

Request Review

@rachaelrenk rachaelrenk added the warpy-factory Opened by the Warp factory agents label Sep 21, 2026
@warp-for-oss

warp-for-oss Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@rachaelrenk

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@warp-for-oss warp-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR broadens the internal aeo_crosslink_audit skill so its recurring cross-link audit includes the existing Warp Factories docs alongside agents, cloud agents, and orchestration. The change is limited to skill instructions and PR/no-change report templates; no public documentation pages, commands, code examples, or product behavior claims are changed.

Concerns

  • No blocking concerns found.
  • The supplemental security pass found no new secret-handling or unsafe external-call issue in the changed lines.
  • No approved or repository spec context was provided, so there was no implementation/spec drift to assess.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • PR description, "Why" section — [SUGGESTION] Claims the skill "could only link into Factories docs from in-scope pages, never audit Factories pages themselves as sources," but the cited run log contradicts this: PR #612 edited src/content/docs/factories/index.mdx and factories/factory-agents.mdx, and PR #691 edited factories/factory-dashboard.mdx, both adding outbound links from Factories pages (i.e. auditing them as sources). Requested resolution: revise the rationale to say the gap being closed is systematic, equal-footing scanning of Factories as a topic, not a literal prior inability to edit Factories pages as sources.

Verdict

Approve with nits

@rachaelrenk rachaelrenk self-assigned this Sep 21, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • .agents/skills/aeo_crosslink_audit/SKILL.md:25 — [SUGGESTION] The new Factories bullet in the Scope list ("Factories (src/content/docs/factories/) — audited as both source pages ... on the same footing as the other three topics") is a full descriptive clause while sibling bullets (Agents, Cloud agents, Orchestration) are bare nouns. Requested change: trim the bullet to Factories (src/content/docs/factories/) and move the source/target-page nuance to a short sentence after the list for consistency.

Verdict

Approve

@warp-agent-staging warp-agent-staging Bot added the factory:docs-factory Label associated to the "docs-factory" factory label Sep 22, 2026
@warp-agent-staging

Copy link
Copy Markdown
Contributor

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation View on Slack

@warp-agent-staging warp-agent-staging Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full diff at a01a8890. The companion outer-loop scope is now aligned with the audit's Factories expansion; no remaining findings.

Responding as Docs Factory (V2): Open session

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

The independent agent completed its review for this commit.

Findings

  • PR body ## Changes section — [SUGGESTION] Lists edits only to .agents/skills/aeo_crosslink_audit/SKILL.md, omitting the accompanying edit to .agents/skills/improve-aeo-crosslink-skill/SKILL.md:85. Requested resolution: add a bullet describing the improve-aeo-crosslink-skill edit so the description matches the full 2-file diff.
  • .agents/skills/improve-aeo-crosslink-skill/SKILL.md:85 — [NIT] "Scope (agents, cloud agents, orchestration, Warp Factories) is too narrow..." mixes the branded product name into an otherwise lowercase topic list, unlike the sibling aeo_crosslink_audit/SKILL.md, which consistently uses lowercase 'factories'. Requested resolution: change to "orchestration, factories" for consistency.

Verdict

Approve with nits

@rachaelrenk
rachaelrenk merged commit 3d9a3d2 into main Sep 22, 2026
16 of 17 checks passed
@warp-agent-staging

Copy link
Copy Markdown
Contributor

Your GitHub account is not connected to Warp. Connect it here.

@rachaelrenk
rachaelrenk deleted the docs/aeo-crosslink-audit-add-factories branch September 22, 2026 16:37

This branch was successfully deployed

1 active deployment
Preview a01a8890 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed factory:docs-factory Label associated to the "docs-factory" factory warpy-factory Opened by the Warp factory agents

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants