docs(skills): harden aeo_crosslink_audit from GROW-6087 run evaluation - #784
rachaelrenk wants to merge 1 commit into
Conversation
Concrete improvements identified from reviewing all 9 completed runs against actual PR history (merge outcomes, review findings), not just aggregate run-log stats: - Add a cross-link-only diff gate to self-review, so an unrelated tooling/workflow change never rides along in a cross-link PR again (seen in PR #691, which bundled a 159-line review-workflow change). - Add a 'prefer the most specific target page' link-quality rule, so a source page naming a specific sub-workflow (e.g. factory automation schedules) links to the matching specific page instead of a general one (seen in PR #612, corrected before merge). - Codify the PR-body integrity check (check_pr_body.py plus a re-fetch-and-verify loop against the live PR) as a mandatory step for every body update this skill makes, since generated PR-body text has twice shipped corrupted to a live PR (#775, #779) before being caught manually. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the aeo_crosslink_audit skill with narrower link-target guidance, an explicit cross-link-only diff gate, and mandatory PR body integrity checks for generated PR descriptions.
Concerns
- No blocking concerns found in the attached diff.
- No security findings identified.
- No spec drift identified; the attached spec context says no approved or repository spec context was found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This branch was successfully deployed
1 participant
Summary
Hardens the
aeo_crosslink_auditskill with three concrete improvements identified while evaluating all 9 completed runs for GROW-6087. Findings and the go/no-go decision were posted as a comment on that Linear issue.Why
The evaluation reviewed actual PR history (merge outcomes, review findings) rather than just aggregate run-log stats, and found three recurring, fixable failure modes.
Changes
.agents/skills/aeo_crosslink_audit/SKILL.mdgit diff --name-onlycheck, so an unrelated tooling or workflow change never rides along in a cross-link PR again. PR docs: add AEO cross-links for agents and orchestration #691 bundled a 159-line review-workflow change into what should have been a small cross-link PR.check_pr_body.py, submit with--body-file, then re-fetch the live body and diff it against the draft, repeating until clean. Generated PR-body text has shipped corrupted to a live PR twice (docs: add AEO cross-links for agents and orchestration #775, docs(skills): expand aeo_crosslink_audit scope to include Factories #779) before being caught and fixed manually; this codifies the fix as a required step instead of an ad hoc practice.Documentation risk
Risk: low
Rationale: Skill-infra-only change to aeo_crosslink_audit/SKILL.md; no src/content/docs/ pages touched, no new product claims.
Docs override: none
Unverified claims
Co-Authored-By: Warp agent@warp.dev