Skip to content

release: keep the dist build-setup steps out of GitHub's workflow directory #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierre-warnier merged 1 commit into from
Sep 15, 2026
+7 −3
Merged

release: keep the dist build-setup steps out of GitHub's workflow directory #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-setup.yml → .github/workflows/setup/build-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Steps dist inserts into each build job before it installs the apt
# dependencies from dist-workspace.toml and runs `dist build`.
# dependencies from dist-workspace.toml and runs `dist build`. Not a workflow:
# it lives one directory down so that GitHub does not read it as one.
#
# dist runs `apt-get install` without `-y`. On GitHub's own runners that is
# harmless, because their apt is configured to assume yes; inside the
Expand Down
7 changes: 5 additions & 2 deletions dist-workspace.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,11 @@ features = ["pam"]
# pull request, which is the release step that can actually break.
pr-run-mode = "skip"
# Steps run in each build job before the apt dependencies below are installed:
# see the file for why.
github-build-setup = "build-setup.yml"
# see the file for why. The path is relative to .github/workflows; the file
# sits in a subdirectory because GitHub reads every YAML file directly under
# .github/workflows as a workflow, and a bare list of steps is not one -- it
# showed up as a failing workflow on every push.
github-build-setup = "setup/build-setup.yml"

# Ship only the multicall binary. `shadow-rs-completions` is a build-time
# helper behind `required-features = ["completions"]`, so it is not part of a
Expand Down