release: keep the dist build-setup steps out of GitHub's workflow directory - #313
Merged
Merged
Conversation
…ectory GitHub reads every YAML file directly under .github/workflows as a workflow. The build-setup file added for dist is a bare list of steps, not a workflow, and GitHub reported it as a failing one on every push to main since #312. dist resolves github-build-setup relative to .github/workflows, so the file moves one directory down, where GitHub does not look. release.yml regenerated: identical, the steps it inlines are the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub reads every YAML file directly under
.github/workflowsas a workflow. The build-setup file added for dist in #312 is a bare list of steps, not a workflow, and GitHub has reported it as a failing workflow on every push to main since. dist resolvesgithub-build-setuprelative to.github/workflows, so the file moves to.github/workflows/setup/, where GitHub does not look.release.ymlregenerated with dist 0.33.0: identical, the inlined steps are the same;dist planstill yields the nine artifacts.