Auto: sync versions [master] - #5227
Conversation
There was a problem hiding this comment.
Pull request overview
Automated update of the imported Calico IPPool CRDs in pkg/imports/crds/ as part of the scheduled make gen-versions sync into master, bringing schema/validation changes from upstream Calico into the operator repo.
Changes:
- Tighten the documented
blockSizeranges for IPv4/IPv6 pools in both Calico v1 and v3 IPPool CRDs. - Add additional CEL validations to the IPPool schema (e.g., strictly masked CIDRs, link-local overlap checks, blockSize range enforcement, and minimum pool size relative to block size).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml | Updates IPPool blockSize description and adds multiple new CEL validation rules. |
| pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml | Mirrors the IPPool blockSize description update and new CEL validations for the v1 CRD. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6. | ||
| The block size must be between 0 and 32 for IPv4 and between 0 and 128 for IPv6. It must also be smaller than | ||
| or equal to the size of the pool CIDR. | ||
| The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller | ||
| than or equal to the size of the pool CIDR. | ||
| maximum: 128 | ||
| minimum: 0 |
| The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6. | ||
| The block size must be between 0 and 32 for IPv4 and between 0 and 128 for IPv6. It must also be smaller than | ||
| or equal to the size of the pool CIDR. | ||
| The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller | ||
| than or equal to the size of the pool CIDR. | ||
| maximum: 128 | ||
| minimum: 0 |
8d097c1 to
22ffb9d
Compare
|
Removing "merge-when-ready" label due to new commits |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:97
- The
blockSizedescription states it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema still allows0(minimum: 0) and the validations below explicitly allowblockSize == 0(likely meaning “use default”). This makes the CRD field documentation misleading for API consumers.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:72
- The
blockSizedescription says it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema still allows0(minimum: 0) and the validations below allowblockSize == 0(likely to mean “use default”). This is inconsistent and may confuse users reading the CRD schema docs.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
22ffb9d to
47e0561
Compare
|
Removing "merge-when-ready" label due to new commits |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:97
- The blockSize schema/validation allows omitting the field or setting it to 0 (see x-kubernetes-validations below), but this description now states it must be between 20–32 (IPv4) / 116–128 (IPv6). That’s misleading for users and client-side docs; clarify that the range applies only when blockSize is explicitly set and non-zero.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:72
- The blockSize schema/validation allows omitting the field or setting it to 0 (see x-kubernetes-validations below), but this description now states it must be between 20–32 (IPv4) / 116–128 (IPv6). That’s misleading for users and client-side docs; clarify that the range applies only when blockSize is explicitly set and non-zero.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
47e0561 to
4d3e3ff
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (4)
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:97
- The blockSize description now says it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema and CEL validations still allow the field to be omitted or explicitly set to 0 to use the per-family defaults. This is confusing for users reading CRD docs. Consider documenting the "unset/0 means default" behavior explicitly.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:231
- This validation message states blockSize must be between 20–32 / 116–128, but the rule also permits blockSize to be unset or set to 0 (use default). The message should mention 0/unset to match the actual accepted values.
blockSize must be between 20 and 32 for IPv4 pools, and between
116 and 128 for IPv6 pools
reason: FieldValueInvalid
rule:
"!has(self.blockSize) || self.blockSize == 0 || (cidr(self.cidr).ip().family()
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:72
- The blockSize description now says it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema and CEL validations still allow the field to be omitted or explicitly set to 0 to use the per-family defaults. This is confusing for users reading CRD docs. Consider documenting the "unset/0 means default" behavior explicitly.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:206
- This validation message states blockSize must be between 20–32 / 116–128, but the rule also permits blockSize to be unset or set to 0 (use default). The message should mention 0/unset to match the actual accepted values.
blockSize must be between 20 and 32 for IPv4 pools, and between
116 and 128 for IPv6 pools
reason: FieldValueInvalid
rule:
"!has(self.blockSize) || self.blockSize == 0 || (cidr(self.cidr).ip().family()
4d3e3ff to
94748b6
Compare
|
Removing "merge-when-ready" label due to new commits |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (2)
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:97
- The blockSize description says it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema and CEL validation explicitly allow blockSize == 0 (and also allow it to be omitted). This makes the CRD description misleading for users who rely on it for configuration guidance.
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:72
- The blockSize description says it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema and CEL validation explicitly allow blockSize == 0 (and also allow it to be omitted). This makes the CRD description misleading for users who rely on it for configuration guidance.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
Automated sync of versions and CRDs from Calico and Calico Enterprise into
masterviamake gen-versions.Triggered by scheduled workflow.