Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sqlite_utils/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ def types_for_column_types(
t = str
elif len(types) == 1:
t = next(iter(types))
# But if it's a subclass of list / tuple / dict, use str
# But if it's a subclass of list / tuple / dict / set, use str
# instead as we will be storing it as JSON in the table
for superclass in (list, tuple, dict):
for superclass in (list, tuple, dict, set, frozenset):
if issubclass(t, superclass):
t = str
elif {int, bool}.issuperset(types):
Expand Down
9 changes: 9 additions & 0 deletions tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,12 @@ def test_flatten(input, expected):
)
def test_dedupe_keys(input, expected):
assert utils.dedupe_keys(input) == expected


def test_types_for_column_types_set_maps_to_str():
"""set and frozenset should be mapped to str for JSON storage, like list/tuple/dict"""
result = utils.types_for_column_types({"tags": {set}})
assert result["tags"] is str

result = utils.types_for_column_types({"tags": {frozenset}})
assert result["tags"] is str
Loading