fix: treat set/frozenset as JSON-storable types in types_for_column_types - #868
Closed
KooshaPari wants to merge 1 commit into
Closed
KooshaPari wants to merge 1 commit into
KooshaPari wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
types_for_column_types()mappedlist,tuple, anddicttostrfor JSON storage, but notsetorfrozenset. This meant columns containing onlysetvalues would be detected as typesetinstead ofstr, which is not a valid SQLite type.Fix
Added
setandfrozensetto the superclass check intypes_for_column_types()so they are mapped tostr, consistent with how other collection types are handled.Testing
test_types_for_column_types_set_maps_to_strto verify bothsetandfrozensetmap tostrtest_utils.pypass📚 Documentation preview 📚: https://sqlite-utils--868.org.readthedocs.build/en/868/