Skip to content

fix: add input validation to chunks() for size < 1 #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KooshaPari wants to merge 1 commit into from
Closed

fix: add input validation to chunks() for size < 1 #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sqlite_utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,8 @@ def chunks(sequence: Iterable[T], size: int) -> Iterable[Iterable[T]]:
:param sequence: Any Python iterator
:param size: The size of each chunk
"""
if size < 1:
raise ValueError(f"chunk size must be at least 1, got {size}")
iterator = iter(sequence)
for item in iterator:
yield itertools.chain([item], itertools.islice(iterator, size - 1))
Expand Down
10 changes: 10 additions & 0 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ def test_chunks(size, expected):
assert chunks == expected


def test_chunks_size_zero_raises():
with pytest.raises(ValueError, match="chunk size must be at least 1"):
list(utils.chunks([1, 2, 3], 0))


def test_chunks_negative_size_raises():
with pytest.raises(ValueError, match="chunk size must be at least 1"):
list(utils.chunks([1, 2, 3], -1))


def test_hash_record():
expected = "d383e7c0ba88f5ffcdd09be660de164b3847401a"
assert utils.hash_record({"name": "Cleo", "twitter": "CleoPaws"}) == expected
Expand Down
Loading