fix: add input validation to chunks() for size < 1 - #864
Closed
KooshaPari wants to merge 1 commit into
Closed
KooshaPari wants to merge 1 commit into
KooshaPari wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
chunks()withsize=0or negative size raised an unhelpfulValueError: Stop argument for islice() must be None or an integer: 0 <= x <= sys.maxsizeinstead of a clear error message.Fix
Added input validation at the start of
chunks()that raisesValueErrorwith a descriptive message:"chunk size must be at least 1, got {size}".Testing
test_chunks_size_zero_raisesto verify size=0 raises ValueErrortest_chunks_negative_size_raisesto verify negative sizes raise ValueErrortest_utils.pypass📚 Documentation preview 📚: https://sqlite-utils--864.org.readthedocs.build/en/864/