fix: sync branch, pull failures, and UTF-8 diffs - #25
Merged
Conversation
Use decodeBase64 instead of atob so diffs handle multi-byte UTF-8 correctly. Rename the unused _branch parameter now that pullFile forwards it.
Match SyncService: an empty or '/' subfolderPath means the repository root, so Diff and GitHub actions must not prefix paths with '/'.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the safe bugfixes from #24 without the GB18030/Big5/Shift-JIS autodetection.
getFileContentwhen pulling filesdecodeBase64instead ofatob)Non-UTF-8 encoding autodetection remains on #24 for discussion.
Test plan
npm test(123 passing)subfolderPathset and confirm the remote path is prefixed