Fix sync status and diff handling for branch/subfolder text files - #24
Fix sync status and diff handling for branch/subfolder text files#24lukelzlz wants to merge 2 commits into
Conversation
|
Hi. @lukelzlz - sorry it has taken me so long to review this, I had not seen the GitHub notifications. I am taking a look right now... |
|
Firstly, thanks again @lukelzlz for the PR, I really appreciate it and some of these bugs are something I came here to work on. I have cherry-picked the, pull-failure, subfolder-path, and UTF-8 This PR can keep the GB18030/Big5/Shift-JIS autodetection so we can discuss that separately. From what I understand, Obsidian only supports UTF-8 - Encoding Auto-Fix is a useful plugin designed to support other formats, but it is not a straight GB18030 loop:
I understand what you are trying to do, but I wonder if this aspect needs some improvement? |
b2de1ef to
d55e22b
Compare
d55e22b to
f58d2b7
Compare
|
Hi @rhoades-brown, That makes total sense. Keeping it strictly UTF-8 avoids false-positive decoding and stays aligned with Obsidian's core expectations, so let's skip the multi-encoding try-catch fallback. I saw that #25 has already been merged—thanks for quickly reviewing and integrating the fixes! I'll go ahead and close this PR now. Thanks again for maintaining the project! |
What changed
Why
Sync and diff behavior could be misleading in a few important cases:
Impact
Validation
npm testnpm run build