Honor ERRMODE_SILENT in pdo_raise_impl_error - #23070
Open
iliaal wants to merge 1 commit into
Open
Conversation
pdo_raise_impl_error stored the SQLSTATE then still emitted E_WARNING even when the handle error mode was SILENT. The early return for SILENT was present but disabled (#if 0). Copy the error code first so errorInfo() remains valid, then return without warning. Closes phpGH-23070
iliaal
force-pushed
the
fix/pdo-silent-impl-error-master
branch
from
August 5, 2026 13:28
1226f78 to
c7e7e4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERRMODE_SILENT is documented to record the error without raising anything, but pdo_raise_impl_error falls through to php_error_docref for every mode except EXCEPTION, so
$pdo->getAttribute(123456)warns under SILENT. The early return is there, disabled behind #if 0, because returning ahead of the memcpy left errorInfo() reporting the previous SQLSTATE. Copying the code first and returning after it drops the warning and keeps errorInfo() accurate. GH-12032 reported the same behaviour, and the suggestion there was that changing it may want internals discussion, so this targets master rather than a stable branch.