Honor ERRMODE_SILENT in pdo_raise_impl_error - #217
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
pdo_raise_impl_error stored the SQLSTATE then still emitted E_WARNING even when the handle error mode was SILENT. The early return for SILENT was present but disabled (#if 0). Copy the error code first so errorInfo() remains valid, then return without warning.
This was referenced Aug 5, 2026
Owner
Author
|
Promoted upstream as php#23070, rebased onto master. phpGH-12032 records a maintainer read that the warning under ERRMODE_SILENT is intended, so this is not a stable-branch change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdo_raise_impl_error stored the SQLSTATE then still emitted E_WARNING under ERRMODE_SILENT. The early return was present but disabled under #if 0. Copy the error code first so errorInfo() stays valid, then return without warning.