fix(web-api): remove false-success stub for token/refresh - #351
Merged
Conversation
Ibochkarev
added
priority: critical
11 tasks
Ibochkarev
force-pushed
the
fix/334-token-refresh-stub
branch
from
July 23, 2026 16:08
fd44881 to
5da91ce
Compare
16 tasks
Ibochkarev
force-pushed
the
fix/334-token-refresh-stub
branch
from
July 24, 2026 02:17
5da91ce to
143fb86
Compare
16 tasks
Ibochkarev
force-pushed
the
fix/334-token-refresh-stub
branch
3 times, most recently
from
August 1, 2026 09:33
e246ee4 to
c8058b9
Compare
POST /customer/token/refresh returned success while unimplemented. Remove the dead route, whitelist entry, and unused TokenManager helper. Closes modx-pro#334.
Ibochkarev
force-pushed
the
fix/334-token-refresh-stub
branch
from
August 2, 2026 01:57
c8058b9 to
0d2c49e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
POST /api/v1/customer/token/refreshотдавалResponse::successс текстом «not implemented yet». Клиент мог решить, что сессия обновлена.Маршрут удалён вместе с whitelist-записью в
TokenMiddlewareи мёртвымTokenManager.refreshToken(). Lifecycle токена остаётся черезGET /token/getи sliding renew в middleware.Тип изменений
Связанные Issues
Closes #334
Как это было протестировано?
php -lна изменённых PHP-файлахphp core/components/minishop3/tests/TokenRefreshRouteRemovedTest.php→ OKРучное тестирование
Автоматические тесты (PHPStan, ESLint)
Тестирование на разных версиях PHP/MODX
Конфигурация тестирования:
fix/334-token-refresh-stubСкриншоты (если применимо)
Чеклист
Дополнительные заметки
Клиенты, которые звали
POST /token/refreshи верилиsuccess, получат 404 роутера вместо ложного успеха. Access/refresh pair в коде не было — это намеренное исправление контракта, не полное удаление auth.Лексикон не добавлялся: при удалении маршрута ответа с сообщением нет.