fix(customer): reject expired API tokens instead of silent renew - #396
Merged
Conversation
4 tasks
Ibochkarev
force-pushed
the
fix/371-expired-api-token-no-renew
branch
from
July 23, 2026 16:07
8ab734a to
f120e18
Compare
Align TokenMiddleware and TokenService with AuthManager: remove expired TYPE_API tokens and return 401 so clients must refresh or log in.
Ibochkarev
force-pushed
the
fix/371-expired-api-token-no-renew
branch
from
July 24, 2026 02:15
f120e18 to
89531ca
Compare
Member
|
Security-fix (token lifecycle) — валидировал актуальную rebase'нутую версию (89531ca): тест Закрыты две дыры:
Разобрали влияние на корзину (по факту кода):
Design-граница: PHP session без токена по-прежнему допускает Follow-up (не блокер): working Для CHANGELOG: истёкший API-токен теперь reject'ится (401 Мержим. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Истёкший
TYPE_APIтокен больше не продлевается с тем же string.TokenService::resolveApiToken()удаляет запись (какAuthManager::validateToken),TokenMiddlewareна protected routes отвечает401+ms3_err_token_expired, чистит cookie и session (customer_idтоже).Без этого утечка Bearer/cookie давала бессрочный доступ.
/token/refresh(#334) — отдельный баг; здесь только reject, не rotation.Тип изменений
Связанные Issues
Closes #371
Как это было протестировано?
ApiTokenExpiryPolicyTest+ existing smoke)Конфигурация тестирования:
fix/371-expired-api-token-no-renewСкриншоты (если применимо)
Чеклист
ms3_err_token_expiredуже былnpm run lint:ciдля Vue)Дополнительные заметки
customer_idв PHP session; если token есть (Bearer/cookie) — всегда валидируется в БД./token/refresh([Bug] Web API: /token/refresh возвращает success, хотя не реализован #334 / fix(web-api): remove false-success stub for token/refresh #351).