Skip to content

Fail loudly when discovery is configured but symfony/finder is missing #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Faneraiy14 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Fail loudly when discovery is configured but symfony/finder is missing #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Server/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
use Mcp\Capability\RegistryInterface;
use Mcp\Exception\InvalidArgumentException;
use Mcp\Exception\LogicException;
use Mcp\Exception\RuntimeException;
use Mcp\JsonRpc\MessageFactory;
use Mcp\Schema\Annotations;
use Mcp\Schema\Enum\ProtocolVersion;
Expand Down Expand Up @@ -1037,7 +1038,13 @@ private function resolve(): array
$discoverer = $this->discoverer ?? $this->createDiscoverer($logger);
$loaders[] = new DiscoveryLoader($this->discoveryBasePath, $this->discoveryScanDirs, $this->discoveryExcludeDirs, $discoverer, $this->discoveryNamePatterns, $logger);
} else {
$logger->warning('File-based discovery requires symfony/finder. Skipping automatic discovery. Run: composer require symfony/finder');
// Warning-and-skip here used to route around the identical guard in
// Discoverer::__construct(), turning a configured-but-impossible feature
// into a silent no-op: build() succeeds, initialize succeeds, and
// tools/list quietly returns an empty array with no actionable signal
// beyond a single log line. setDiscovery() is an explicit request for
// file-based discovery, so failing to honor it must fail loudly.
throw new RuntimeException('File-based discovery requires symfony/finder. Run: composer require symfony/finder');
}
}

Expand Down