Fail loudly when discovery is configured but symfony/finder is missing - #464
Open
Faneraiy14 wants to merge 1 commit into
Open
Conversation
Builder::build() previously routed around Discoverer::__construct()'s own class_exists(Finder::class) guard: instead of throwing, it logged a single warning and silently skipped the DiscoveryLoader. The result is the worst failure mode available - the server builds successfully, initialize succeeds, and tools/list quietly returns an empty array, with no actionable signal beyond one log line the operator may never see. setDiscovery() is an explicit request for file-based discovery; if that request can't be honored, build() should fail immediately with the same RuntimeException and message Discoverer already throws for the identical condition, rather than downgrading a configured-but- impossible feature to a whisper. Fixes modelcontextprotocol#398
Faneraiy14
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
August 19, 2026 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builder::build()routed aroundDiscoverer::__construct()'s ownclass_exists(Finder::class)guard: instead of throwing, it logged a single warning and silently skipped theDiscoveryLoader. The result is the worst failure mode available — the server builds successfully,initializesucceeds, andtools/listquietly returns an empty array, with no actionable signal beyond one log line the operator may never see.setDiscovery()is an explicit request for file-based discovery; if that request can't be honored,build()should fail immediately with the sameRuntimeExceptionand messageDiscovereralready throws for the identical condition, rather than downgrading a configured-but-impossible feature to a whisper.Fixes #398
Test plan
vendor/bin/phpunit --testsuite=unit— 1513 tests, 3919 assertions, all passingvendor/bin/phpunit --testsuite=integration— 64 tests, 145 assertions, all passingvendor/bin/phpstan analyse(full repo, level 6 perphpstan.dist.neon) — no errors