docs: label cardinality on the README diagram - #61
Merged
Merged
Conversation
The line joining dim_customer and fct_order carried no notation, so the picture showed that the two models were related without showing how. It now reads 1 at the dimension and * at the fact, matching the Power BI style labels the canvas itself renders, so the diagram says one customer to many orders rather than leaving it to be inferred from the key names. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014ywafwDpxdWWBt26Q1keiP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Simple by design" diagram joined
dim_customerandfct_orderwith an unlabelled line, so it showed that the two models were related without showing how. The relationship is now labelled 1 at the dimension and * at the fact.The notation matches what ERD Studio actually renders on the canvas:
FkEdge.tsxuses Power BI-style labels, a 14px1and a deliberately larger 22px*, rather than crow's feet. The diagram now reflects the product instead of inventing its own convention.Source is
docs/assets/readme-workflow.svg, re-exported tomedia/readme-workflow.pngat 2240x792 withrsvg-convert. The PNG is excluded from the.vsix, so the published extension bytes are unchanged.Test plan
1sits at thedim_customerend,*at thefct_orderend, neither overlapping a node bordervsce lsstill lists 12 files; the diagram is not among themv1.0.1tag and GitHub Release🤖 Generated with Claude Code
https://claude.ai/code/session_014ywafwDpxdWWBt26Q1keiP