Skip to content

docs/TRANSLATING.md: fix translators-list file reference #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcfnord wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

docs/TRANSLATING.md: fix translators-list file reference #3795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/TRANSLATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ To add a new translation to the Installer (while undertaking the above steps wit

Start translating the new language using Hosted Weblate or Git (as described in the first section of this guide). If you plan to work on the translation for a longer period, please contact the administrators to be invited to the Jamulus organisation as well as translators channel on Discord or Matrix.

Since every contributor can and should be added to the in-app contributor list, please remind us to add you to the `src/utils.h` file as translator or open a pull request yourself.
Since every contributor can and should be added to the in-app contributor list, please remind us to add you to the translators list in `src/util.cpp` (in `CAboutDlg::CAboutDlg()`) or open a pull request yourself.

@ann0see ann0see Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since every contributor can and should be added to the in-app contributor list, please remind us to add you to the translators list in `src/util.cpp` (in `CAboutDlg::CAboutDlg()`) or open a pull request yourself.
Since every contributor can and should be added to the in-app contributor list, please remind us to add you to the translators list in `src/util.cpp` or open a pull request yourself.

As the method name may get changed some time. As before, I expect humans and agents to find it e.g with grep.
We might want to update the comment to say translators list

@pljones pljones Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally it wouldn't need a C++ file editing, it would be a plain text file preprocessed into a static value included at compile time... That's for another time. But my point is the file name could change just as easily.


---

Expand Down