feat(brand): render the GitHub social preview from the luminary field - #296
Conversation
The repository had no social preview, so links to it rendered as a bare text card. The brand build now emits github-social.png at 1280x640: the luminary nebula field with the triskelion mark over the glowing wordmark, the same composition the installer art uses, sized to GitHub's card. One copy is checked in under assets/brand/social because GitHub has no API for the preview and it is uploaded by hand from Settings. The existing github-banner.png fit the horizontal lockup by height only, and the lockup is wider than 4:1, so it ran past both edges of the 1280x640 canvas. It now fits by width first. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dXbUNEe4yxrGhQLXbzRou
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe brand build now fits the GitHub banner by width, caps its height, and generates a 1280×640 social preview. The README documents the checked-in preview, upload location, and regeneration workflow. ChangesBrand social preview
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The brand build and social preview asset are internally consistent, with no established merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Comment |
The wordmark sat low enough that the composition read as two separate elements. Pulling it up under the mark makes the lockup one group again while keeping both clear of GitHub's card crop. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dXbUNEe4yxrGhQLXbzRou
What this changes
The brand build gains a GitHub social preview output:
github-social.pngat 1280x640, the luminary nebula field with the triskelion mark over the glowing wordmark, the same composition the installer art already uses. One rendered copy is checked in atassets/brand/social/hypercolor-social.pngso the image the repo settings page carries has a source of truth in git. The existinggithub-banner.pngalso stops clipping: it fit the horizontal lockup by height only, and that lockup is wider than 4:1, so it overran both edges.Why
The repository has no social preview, so a link to it on Hacker News, Slack, or Mastodon renders as a plain text card. SilkCircuit ships a proper one; Hypercolor should walk in with the same energy.
Verification
uv run assets/brand/build.pystage code executed against the checked-in masters through the module'sbuild_socialentry point; both outputs render at 1280x640 and were inspected visually (the checked-in PNG is that render).The brand README documents the new directory and the manual upload step. GitHub has no API for the social preview, so setting it is a one-time click under Settings, General, Social preview.
Added or updated tests (not applicable; brand asset build)
Added or updated docs (README, AGENTS.md, relevant spec, or guide)
just verifypasses locally (not applicable; no Rust changes)just denypasses (not applicable)just ui-testandjust ui-buildpass (not applicable)just sdk-lint,just sdk-check, andjust sdk-buildpass (not applicable)just python-verifypasses (not applicable)just compat-checkpasses (not applicable)just docs-buildpasses (not applicable; brand README is not part of the site)cd docs && zola checkpasses (not applicable)Packaging scripts were syntax-checked (not applicable)
just e2e-buildpasses with the normal Servo stack (not applicable)just e2e-build-cpupasses when validating the CPU smoke fallback (not applicable)just e2epasses against the Servo stack (not applicable)Tested on real hardware, simulator, or e2e harness (not applicable)
🤖 Generated with Claude Code
https://claude.ai/code/session_013dXbUNEe4yxrGhQLXbzRou
Summary by CodeRabbit