docs(readme): open with the lockup banner above the hero screenshot - #297
Merged
Merged
Conversation
The README led with the dashboard screenshot and a plain text heading, so the first thing a visitor saw was product UI with no brand. The header now opens with the horizontal lockup on the luminary chip, keeps the tagline, and puts the dashboard hero directly beneath it so the logo and the product read as one block, the way the SilkCircuit README does. The banner is a new brand build output, readme-banner.png, checked in next to the social preview under assets/brand/social. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dXbUNEe4yxrGhQLXbzRou
|
Warning Review limit reached
On-demand reviews are free for the next 4 days. After that, they cost $0.25 per reviewed file. Or wait 44 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Comment |
The neon underline reads as a floor under the lockup when the banner sits above a screenshot. The chip is now the lockup on the gradient alone, 40px shorter since the underline no longer needs room. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dXbUNEe4yxrGhQLXbzRou
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The README opens with the Hypercolor lockup banner instead of a bare text heading, keeps the tagline, and places the dashboard hero screenshot directly beneath so the brand and the product read as one block. The banner is a new brand build output (
readme-banner.png, the horizontal lockup on the luminary chip with the neon underline) checked in next to the social preview.Why
The first thing a visitor saw was product UI with no brand on it. SilkCircuit opens with its lockup banner and then the screenshot; Hypercolor now does the same, and the hero stays within one scroll of the logo.
Verification
Rendered through the brand build's
build_socialentry point against the checked-in masters; the social preview output is byte-identical to the one merged in feat(brand): render the GitHub social preview from the luminary field #296, so only the banner is new.README header inspected as raw Markdown; the image path is repository-relative and resolves on the branch.
Added or updated tests (not applicable)
Added or updated docs (README, AGENTS.md, relevant spec, or guide)
just verifypasses locally (not applicable; no Rust changes)just denypasses (not applicable)just ui-testandjust ui-buildpass (not applicable)just sdk-lint,just sdk-check, andjust sdk-buildpass (not applicable)just python-verifypasses (not applicable)just compat-checkpasses (not applicable)just docs-buildpasses (not applicable; the README is not part of the Zola site)cd docs && zola checkpasses (not applicable)Packaging scripts were syntax-checked (not applicable)
just e2e-buildpasses with the normal Servo stack (not applicable)just e2e-build-cpupasses when validating the CPU smoke fallback (not applicable)just e2epasses against the Servo stack (not applicable)Tested on real hardware, simulator, or e2e harness (not applicable)
🤖 Generated with Claude Code
https://claude.ai/code/session_013dXbUNEe4yxrGhQLXbzRou