fix: include service name in help usage#866
Conversation
Fixes googleworkspace#839 Co-Authored-By: bridge <bridge@nousresearch.com>
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the help usage output for nested service commands was missing the service name. By explicitly setting the bin_name for the Clap command tree, the CLI now correctly renders the full invocation path in help documentation, improving the user experience for command discovery. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the CLI initialization in crates/google-workspace-cli/src/main.rs to dynamically set the binary name using .bin_name(format!("gws {first_arg}")). This ensures that nested help and usage text render correctly with the full binary invocation. There are no review comments, and I have no feedback to provide.
Summary
Fixes #839
Ensure generated service help renders the full invocation path (for example,
gws sheets spreadsheets) instead of dropping the service name after argv is filtered for Clap.Changes
bin_nametogws <service>before parsing filtered arguments.Test Plan
cargo fmt -- --checkcargo test -q(blocked in this environment: linkerccis not installed, so Rust build scripts for dependencies fail before tests compile)