fix: include service name in help usage#864
Conversation
Fixes googleworkspace#839 Co-Authored-By: bridge <bridge@nousresearch.com>
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the CLI user experience by fixing an issue where the service name was dropped from help/usage output when using nested commands. Additionally, it updates the documentation for several Google Workspace services to include newly supported methods and provide clearer instructions for existing API interactions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the CLI command tree building in src/main.rs by dynamically setting the binary name (bin_name) using the first argument. This ensures that nested help and usage text rendered by Clap correctly displays the full binary invocation (e.g., gws sheets spreadsheets --help instead of starting at gws spreadsheets). There are no review comments, and I have no additional feedback to provide.
|
Superseded by #866, which is rebased onto upstream main to avoid the fork branch conflict. |
Summary
Fixes #839
Ensure generated service help renders the full invocation path (for example,
gws sheets spreadsheets) instead of dropping the service name after argv is filtered for Clap.Changes
bin_nametogws <service>before parsing filtered arguments.Test Plan
cargo fmt -- --checkcargo test -q(blocked in this environment: linkerccis not installed, so Rust build scripts for dependencies fail before tests compile)