Skip to content

fix(attributes): Per-call attribute pollution in logs and metrics#1879

Merged
limbonaut merged 4 commits into
masterfrom
limbonaut/fix/attributes-pollution
Jul 17, 2026
Merged

fix(attributes): Per-call attribute pollution in logs and metrics#1879
limbonaut merged 4 commits into
masterfrom
limbonaut/fix/attributes-pollution

Conversation

@limbonaut

@limbonaut limbonaut commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Fixes per-call attribute pollution when applying attributes with the same key from per-call list and global scope. If the global scope contains an attribute with the same key and additionally specifies unit field, the unit would leak into the telemetry attribute if the per-call one didn't have a unit.

By definition, attributes should be merged atomically, so this PR implements a shallow merge that only considers top-level keys in the attributes map.

@limbonaut limbonaut changed the title WIP: fix(attributes): Per-call attribute pollution in logs and metrics fix(attributes): Per-call attribute pollution in logs and metrics Jul 17, 2026
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.58%. Comparing base (35b83c2) to head (3f3e19f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
+ Coverage   75.54%   75.58%   +0.03%     
==========================================
  Files          90       90              
  Lines       21016    21070      +54     
  Branches     3730     3745      +15     
==========================================
+ Hits        15876    15925      +49     
+ Misses       4318     4312       -6     
- Partials      822      833      +11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@limbonaut
limbonaut merged commit 88e7bae into master Jul 17, 2026
69 checks passed
@limbonaut
limbonaut deleted the limbonaut/fix/attributes-pollution branch July 17, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants