Expose command dispatch timestamp - #27
Merged
Merged
Conversation
stevenaya
force-pushed
the
feat/executed-command-metadata
branch
from
September 4, 2026 14:25
d27b026 to
ed6e6bd
Compare
kou
pushed a commit
that referenced
this pull request
Sep 8, 2026
## Summary - align configured arm limits and numeric precision with the current OpenArm model - use the full J1/J2 range for the pedestal configuration while retaining the cell-specific range - update the gripper limit precision and position-limit tests Follow-up PRs #27 and #23 have been rebased on top of this change. ## Testing - `.venv/bin/pytest -q` (40 passed) - `.venv/bin/ruff check .` Co-authored-by: stevenaya <stevenaya@users.noreply.github.com>
Contributor
|
#28 has been merged. Could you rebase on main? |
stevenaya
force-pushed
the
feat/executed-command-metadata
branch
from
September 8, 2026 07:33
ed6e6bd to
f6e245d
Compare
Contributor
Author
|
Already rebased on main ^^. |
stevenaya
force-pushed
the
feat/executed-command-metadata
branch
from
September 8, 2026 10:12
f6e245d to
18c2544
Compare
Contributor
Author
|
Implementation note for the less obvious choices:
The boolean return was moved to #23, where safety rejection provides meaningful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Downstream nodes need a wall-clock dispatch marker to correlate the command accepted by the driver with external observations. This is a software dispatch timestamp, not motor acknowledgement or physical motion time. The existing monotonic timestamp remains dedicated to velocity limiting.
The boolean send result now belongs to draft PR #23, where safety rejection introduces real
Falsepaths.Validation
pytest(41 passed)ruff check .ruff format --check .