Skip to content

fix stale video - #4209

Queued
paul-nechifor wants to merge 2 commits into
mainfrom
paul/fix/stale2
Queued

paul-nechifor wants to merge 2 commits into
mainfrom
paul/fix/stale2

Conversation

@paul-nechifor

@paul-nechifor paul-nechifor commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

The video feed gets stuck sometimes because of the GC isn't freed frequently enough on Deno.

Closes DIM-1697

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #4209      +/-   ##
==========================================
- Coverage   79.55%   79.55%   -0.01%     
==========================================
  Files        1494     1494              
  Lines      141519   141520       +1     
  Branches    12129    12133       +4     
==========================================
  Hits       112589   112589              
  Misses      25511    25511              
- Partials     3419     3420       +1     
Components Coverage Δ
Tests 95.36% <100.00%> (+<0.01%) ⬆️
Flag Coverage Δ
OS-ubuntu-24.04-arm 75.16% <100.00%> (+<0.01%) ⬆️
OS-ubuntu-latest 75.98% <100.00%> (-0.01%) ⬇️
Py-3.10 75.76% <100.00%> (+<0.01%) ⬆️
Py-3.11 75.96% <100.00%> (-0.01%) ⬇️
Py-3.12 75.97% <100.00%> (+<0.01%) ⬆️
SelfHosted-Large 30.62% <0.00%> (-0.01%) ⬇️
SelfHosted-Linux 36.65% <0.00%> (-0.01%) ⬇️
SelfHosted-macOS 37.00% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/web/relay_bridge/locate.py 72.09% <ø> (ø)
dimos/web/relay_bridge/test_relay_process.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

Not safe to merge until the Docker, development, and systemd relay launch paths enable V8 garbage collection.

Findings

  1. P1 Enable GC in Launchers

Summary

The new forced garbage-collection call only works through the Python-managed relay launcher. The Docker image, development task, and documented systemd service all start the relay without exposing V8 garbage collection, leaving stale-stream cleanup ineffective for those supported deployments.

Update every supported relay launch command before merging so reaped WebTransport streams are finalized consistently.

Reviews (1) · Last reviewed commit: "fix stale video"

Comment thread web/relay/server.ts
@spomichter

Copy link
Copy Markdown
Contributor

resolving conversation to merge

@spomichter
spomichter added this pull request to the merge queue Sep 18, 2026
Any commits made after this event will not be merged.
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/0.0.14 ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants