Conversation
bogwi
added this pull request to stack #4205
September 17, 2026 14:31
bogwi
marked this pull request as ready for review
September 17, 2026 14:32
bogwi
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
September 17, 2026 14:32
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
|
bogwi
force-pushed
the
danvi/fix/remove-skipif-macos-bug-from-green-tests
branch
from
September 18, 2026 02:46
f0ea7ac to
56c4897
Compare
bogwi
force-pushed
the
danvi/fix/remove-skipif-macos-bug-from-green-tests
branch
from
September 18, 2026 03:55
9bc0b60 to
fc4284f
Compare
bogwi
force-pushed
the
danvi/fix/remove-skipif-macos-bug-from-green-tests
branch
from
September 18, 2026 05:54
ddef902 to
76a8ade
Compare
| if TYPE_CHECKING: | ||
| from dimos.memory.store.base import Store | ||
|
|
||
| pytestmark = pytest.mark.macos_ci |
Collaborator
There was a problem hiding this comment.
Are these due to extensions not being loaded? If so, I've fixed this in my PR by using the uv version of Python, rather than the system one.
Member
Author
There was a problem hiding this comment.
no, these are not skips, these are adds with clear intent - add to mac ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove skipif_macos_bug from tests that pass on Darwin.
(9bc0b60) Removed the sqlite-vec Darwin skip and the matching
skipif_macos/skipif_aarch64onTestStandaloneComponents, then markedtest_replay.py,test_store.py, andtest_stream.pywithmacos_ciso Mac self-hosted-tests now runs those 246 tests (they were hosted-only before).