Conversation
bogwi
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
September 17, 2026 06:03
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4200 +/- ##
==========================================
+ Coverage 79.59% 79.61% +0.01%
==========================================
Files 1500 1500
Lines 141760 141769 +9
Branches 12136 12136
==========================================
+ Hits 112835 112868 +33
+ Misses 25501 25495 -6
+ Partials 3424 3406 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bogwi
force-pushed
the
danvi/feat/add-macos-e2e-to-mac-ci
branch
from
September 17, 2026 13:27
0ddf9eb to
3100524
Compare
bogwi
added this pull request to stack #4205
September 17, 2026 14:31
bogwi
force-pushed
the
danvi/feat/add-macos-e2e-to-mac-ci
branch
from
September 18, 2026 02:46
3100524 to
3d739a5
Compare
bogwi
force-pushed
the
danvi/feat/add-macos-e2e-to-mac-ci
branch
from
September 18, 2026 03:55
3d739a5 to
be9274c
Compare
added 3 commits
September 18, 2026 14:53
Register pytest.mark.macos and add it to Mac matrix.markers with native_e2e so Darwin-green hosted e2e stays on hosted Linux tests and also runs on Mac CI.
…tor_joint_state_published
macos was easy to mix with skipif_macos and with Darwin itself. Mac self-hosted-tests still selects the same files via matrix.markers; hosted tests not (...) still omits the marker.
bogwi
force-pushed
the
danvi/feat/add-macos-e2e-to-mac-ci
branch
from
September 18, 2026 05:54
be9274c to
9c7abd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the coordinator, datacollection, daemon, viewer websocket, relay, and relay-bridge e2e tests, plus the livox native loopback, on Mac CI as well as on Linux. Introduce dedicated test marks -
pytest.mark.macos_ci, andpytest.mark.skipif_macos_ci