Skip to content

Select hosted e2e and native_e2e on Mac self-hosted-tests. - #4200

Open
bogwi wants to merge 3 commits into
mainfrom
danvi/feat/add-macos-e2e-to-mac-ci
Open

bogwi wants to merge 3 commits into
mainfrom
danvi/feat/add-macos-e2e-to-mac-ci

Conversation

@bogwi

@bogwi bogwi commented Sep 17, 2026

Copy link
Copy Markdown
Member

Run the coordinator, datacollection, daemon, viewer websocket, relay, and relay-bridge e2e tests, plus the livox native loopback, on Mac CI as well as on Linux. Introduce dedicated test marks - pytest.mark.macos_ci, and pytest.mark.skipif_macos_ci

@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

No blocking findings were identified; the change is safe to merge based on the available evidence.

What we checked:

  • Attempted collection of the CI-equivalent selector across the six newly macOS-marked end-to-end modules and the Livox loopback module. T-Rex
  • Dependency setup halted before pytest collection because PyAudio could not compile without portaudio.h, so no test list or runtime result was produced. T-Rex

Summary

  • Expands the experimental self-hosted macOS test selection to include selected hosted end-to-end suites and the existing native Livox loopback coverage.
  • Adds and applies a macos pytest marker for the hosted suites intended to run on the macOS runner.
  • No actionable issues were identified.

T-Rex validation blocked

  • The targeted macOS test collection could not start because the environment cannot build PyAudio without the PortAudio development header (portaudio.h); the available Linux host also cannot exercise macOS-specific behavior.

Reviews (1) · Last reviewed commit: "Select hosted e2e and native_e2e on Mac ..."

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #4200      +/-   ##
==========================================
+ Coverage   79.59%   79.61%   +0.01%     
==========================================
  Files        1500     1500              
  Lines      141760   141769       +9     
  Branches    12136    12136              
==========================================
+ Hits       112835   112868      +33     
+ Misses      25501    25495       -6     
+ Partials     3424     3406      -18     
Components Coverage Δ
Tests 95.41% <100.00%> (+0.03%) ⬆️
Flag Coverage Δ
OS-ubuntu-24.04-arm 75.17% <100.00%> (+<0.01%) ⬆️
OS-ubuntu-latest 76.00% <100.00%> (+<0.01%) ⬆️
Py-3.10 75.78% <100.00%> (+<0.01%) ⬆️
Py-3.11 75.98% <100.00%> (+<0.01%) ⬆️
Py-3.12 75.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/conftest.py 86.01% <100.00%> (+2.76%) ⬆️
dimos/core/test_e2e_daemon.py 99.31% <100.00%> (+0.69%) ⬆️
dimos/e2e_tests/test_control_coordinator.py 100.00% <100.00%> (ø)
dimos/imitation/test_datacollection_e2e.py 96.42% <ø> (ø)
dimos/visualization/rerun/test_viewer_ws_e2e.py 89.88% <100.00%> (+1.25%) ⬆️
dimos/web/relay_bridge/test_relay_bridge_e2e.py 97.55% <100.00%> (+1.79%) ⬆️
dimos/web/relay_bridge/test_relay_e2e.py 97.30% <100.00%> (+2.71%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added ready-to-merge Required CI checks have passed on this PR and removed ready-to-merge Required CI checks have passed on this PR labels Sep 17, 2026
@bogwi
bogwi force-pushed the danvi/feat/add-macos-e2e-to-mac-ci branch from 0ddf9eb to 3100524 Compare September 17, 2026 13:27
@github-actions github-actions Bot added ready-to-merge Required CI checks have passed on this PR and removed ready-to-merge Required CI checks have passed on this PR labels Sep 17, 2026
@bogwi
bogwi added this pull request to stack #4205 September 17, 2026 14:31
@bogwi
bogwi force-pushed the danvi/feat/add-macos-e2e-to-mac-ci branch from 3100524 to 3d739a5 Compare September 18, 2026 02:46
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Sep 18, 2026
@bogwi
bogwi force-pushed the danvi/feat/add-macos-e2e-to-mac-ci branch from 3d739a5 to be9274c Compare September 18, 2026 03:55
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Sep 18, 2026
bogwi added 3 commits September 18, 2026 14:53
Register pytest.mark.macos and add it to Mac matrix.markers with native_e2e so Darwin-green hosted e2e stays on hosted Linux tests and also runs on Mac CI.
macos was easy to mix with skipif_macos and with Darwin itself. Mac self-hosted-tests still selects the same files via matrix.markers; hosted tests not (...) still omits the marker.
@bogwi
bogwi force-pushed the danvi/feat/add-macos-e2e-to-mac-ci branch from be9274c to 9c7abd1 Compare September 18, 2026 05:54
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant