Skip to content

mark a test as self_hosted - #4190

Merged
leshy merged 1 commit into
mainfrom
danvi/fix/move-test-to-self-hosted
Sep 16, 2026
Merged

leshy merged 1 commit into
mainfrom
danvi/fix/move-test-to-self-hosted

Conversation

@bogwi

@bogwi bogwi commented Sep 16, 2026

Copy link
Copy Markdown
Member

mark def test_detection2d(detection2d) as self_hosted (same as this test's siblings) in dimos/dimos/perception/detection/type/detection2d/test_bbox.py to prevent it loading a large git-lfs asset when uv run pytest --numprocesses=auto dimos command is run.

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

Safe to merge; the test classification behaves as intended.

What we checked:

  • Ran marker-selection-00-command.sh skipif_in_ci and marker-selection-00-command.sh self_hosted from the repository; both completed successfully. T-Rex
  • Recorded the exact executed commands and outcomes, showing that both commands exited with code 0 and that the default expression and explicit -m self_hosted selections behaved as described. T-Rex

Summary

  • Reclassifies the Detection2D bounding-box test as self-hosted so default test runs do not select its resource-heavy fixture.
  • The dedicated self-hosted selection continues to collect the test.

Merge safety

Safe to merge. No blocking issues were found.

Reviews (1) · Last reviewed commit: "mark a test as self_hosted"

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #4190      +/-   ##
==========================================
+ Coverage   79.13%   79.16%   +0.03%     
==========================================
  Files        1471     1471              
  Lines      139520   139520              
  Branches    11988    11988              
==========================================
+ Hits       110409   110452      +43     
+ Misses      25705    25664      -41     
+ Partials     3406     3404       -2     
Components Coverage Δ
Tests 95.00% <100.00%> (+0.08%) ⬆️
Flag Coverage Δ
OS-ubuntu-24.04-arm 75.10% <100.00%> (ø)
OS-ubuntu-latest 75.80% <100.00%> (-0.01%) ⬇️
Py-3.10 75.57% <100.00%> (-0.01%) ⬇️
Py-3.11 75.78% <100.00%> (-0.01%) ⬇️
Py-3.12 75.78% <100.00%> (-0.01%) ⬇️
SelfHosted-Large 30.73% <100.00%> (+<0.01%) ⬆️
SelfHosted-Linux 36.19% <100.00%> (+0.03%) ⬆️
SelfHosted-macOS 35.53% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...perception/detection/type/detection2d/test_bbox.py 100.00% <100.00%> (+93.87%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Sep 16, 2026
@leshy
leshy added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit 416fc30 Sep 16, 2026
39 of 40 checks passed
@leshy
leshy deleted the danvi/fix/move-test-to-self-hosted branch September 16, 2026 15:14
@github-actions

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release/0.0.14:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/0.0.14 PlzReview ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants