You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
unitree-g1-groot-wbc and unitree-g1-teleop cannot start: "ControlCoordinator/start: Joint 'g1/left_shoulder_pitch' is missing an acceleration limit". Sim and hardware.
Root cause
#3844 made joint acceleration limits mandatory and added the default to G1_MANIPULATION_MODEL, but not to G1_TELEOP_ARM_MODEL, which the GR00T blueprint hands to the coordinator. The same PR removed the test that pinned that model.
Solution
G1_TELEOP_ARM_MODEL gets .with_default_joint_acceleration_limit(2.0), same value as the manipulation model. Test prepares the GR00T model config through the planner validation.
How to test
uv run dimos --simulation mujoco run unitree-g1-groot-wbc starts and the G1 stands. uv run pytest dimos/robot/unitree/g1/test_g1_teleop.py
AI assistance
Claude Code (Fable 5.1) assisted extensively with implementation, tests and the PR description under my direction. All hardware validation was done by me on the robot.
No blocking issue was identified in the change, but the focused startup preparation check could not complete without git-lfs.
What we checked:
Authored a narrow probe that imports the actual G1 GR00T WBC coordinator model and invokes planning preparation.
Ran the probe under both the production configuration and a version with the acceleration default removed to compare behavior.
Observed that both runs halted during LFS-backed model resolution with the error RuntimeError: Missing required tools: git-lfs, as shown in the linked logs.
Summary
This change gives the G1 teleoperation arm model the planner-required default joint acceleration limit and adds focused planning-preparation coverage for the coordinator model.
T-Rex validation blocked
The focused G1 planning-preparation check could not reach joint-space validation because resolving the LFS-backed G1 URDF requires the unavailable git-lfs executable.
@TomCC7@aclauer the only change since your approvals moves the new test to the self-hosted runner, it needs the LFS URDF. Could you re-approve? Auto-merge is armed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
unitree-g1-groot-wbcandunitree-g1-teleopcannot start: "ControlCoordinator/start: Joint 'g1/left_shoulder_pitch' is missing an acceleration limit". Sim and hardware.Root cause
#3844 made joint acceleration limits mandatory and added the default to
G1_MANIPULATION_MODEL, but not toG1_TELEOP_ARM_MODEL, which the GR00T blueprint hands to the coordinator. The same PR removed the test that pinned that model.Solution
G1_TELEOP_ARM_MODELgets.with_default_joint_acceleration_limit(2.0), same value as the manipulation model. Test prepares the GR00T model config through the planner validation.How to test
uv run dimos --simulation mujoco run unitree-g1-groot-wbcstarts and the G1 stands.uv run pytest dimos/robot/unitree/g1/test_g1_teleop.pyAI assistance
Claude Code (Fable 5.1) assisted extensively with implementation, tests and the PR description under my direction. All hardware validation was done by me on the robot.
Checklist