build: fetch LFS test data before the suites run - #4106
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4106 +/- ##
==========================================
- Coverage 79.15% 79.14% -0.01%
==========================================
Files 1469 1469
Lines 139237 139237
Branches 11976 11976
==========================================
- Hits 110212 110201 -11
- Misses 25626 25633 +7
- Partials 3399 3403 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
paul-nechifor
previously approved these changes
Sep 13, 2026
spomichter
marked this pull request as ready for review
September 13, 2026 01:00
spomichter
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0 and
spomichter
as code owners
September 13, 2026 01:00
spomichter
previously approved these changes
Sep 13, 2026
spomichter
enabled auto-merge
September 13, 2026 01:02
Contributor
|
KrishnaH96
force-pushed
the
krishna/fix/rel-fetch-test-data
branch
from
September 13, 2026 01:44
295837e to
5e4ad09
Compare
Contributor
Author
|
@spomichter the merge-main commits dismissed your approval, nothing changed in the script since. Could you re-approve? Auto-merge is armed. |
paul-nechifor
approved these changes
Sep 16, 2026
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tests pull their LFS archives lazily inside the test. On a normal link a 1.2 GB archive takes longer than the 600 s per-test timeout: the worker is killed and the session hangs. Same root cause as #2119.
Solution
bin/fetch-test-data pulls every archive a test references; pytest-slow/all/coverage call it first, like build-test-natives. Three setup lines in docs/development/testing.md (fetch, playwright browsers, -n 8 on laptops).
How to test
bin/fetch-test-data && bin/pytest-all --numprocesses=8Lists 40 archives; no in-test LFS pull afterwards.
AI assistance
Used Fable 5.1 extensively for root cause analysis, fix and testing.
Checklist