refactor(grasping): isolate GraspGenX dependencies - #4102
Merged
Merged
Conversation
TomCC7
commented
Sep 12, 2026
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4102 +/- ##
=======================================
Coverage 79.06% 79.06%
=======================================
Files 1466 1466
Lines 138931 138851 -80
Branches 11962 11956 -6
=======================================
- Hits 109842 109781 -61
+ Misses 25687 25673 -14
+ Partials 3402 3397 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TomCC7
commented
Sep 12, 2026
TomCC7
commented
Sep 12, 2026
TomCC7
commented
Sep 13, 2026
TomCC7
commented
Sep 13, 2026
TomCC7
commented
Sep 13, 2026
TomCC7
commented
Sep 13, 2026
TomCC7
marked this pull request as ready for review
September 13, 2026 02:41
TomCC7
requested review from
Dreamsorcerer,
aclauer,
bogwi,
jeff-hykin,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
September 13, 2026 02:41
Contributor
|
This reverts commit 3e54402.
…spgenx # Conflicts: # dimos/experimental/isolated_python/README.md # dimos/experimental/isolated_python/test_module.py
TomCC7
added this pull request to stack #4176
September 16, 2026 00:15
1 task
paul-nechifor
approved these changes
Sep 16, 2026
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/0.0.14
git worktree add -d .worktree/backport/4102-to-release/0.0.14 origin/release/0.0.14
cd .worktree/backport/4102-to-release/0.0.14
git switch --create backport/4102-to-release/0.0.14
git cherry-pick -x 4bfecf65090c9738abef892c1f6b5b0a7f36a489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
User-requested dependency isolation, with the design agreed before implementation. No linked issue or discussion; opening as a draft for review.
Problem
GraspGenX contributes its dependency graph and seven overrides to the main uv project even when its extra is not installed. Its dedicated worker separates execution but still uses the host Python environment.
Solution
IsolatedPythonModule, preserving its proposal RPC and blueprints. Remove its root extra and seven overrides.native/python/, outside the dimOS package. Declarations select a repository-relativeproject_dir.main. No runtime sources or lockfiles are bundled in wheel/sdist artifacts.An installed host and the shared checkout can differ in revision. Existing clones are not updated automatically and must contain the declared runtime project.
How to Test
Verify through the existing visible MuJoCo blueprint:
MUJOCO_GL=glfw dimos --viewer none run xarm-grasp-graspgenx \ --simulation mujoco --headless falseIn a second terminal, run
dimos shell, then:Exit the shell and run
dimos stopafterward.Run runtime tests and type checking from the repository root:
Validation:
dimos shell: a 417-point cloud produced 100 ranked grasps with finite scores and preserved frame/timestamp. The GraspGenX child exited with code 0; overall blueprint shutdown required the CLI SIGKILL escalation.DIMOS_ALLOW_MISSING_COCKPIT=1because compiled cockpit assets were unavailable.The PR also guards unavailable
yourdfpyimports on Linux ARM and clears inherited xdist identity in the nested collection test, addressing earlier CI failures.AI assistance
Codex (GPT-6) performed repository inspection, implementation, testing, and PR preparation from the user-approved plan.
Checklist
Agent: Codex (GPT-6).