Skip to content

fix: persist adopted Volcengine ENI IDs - #17

Merged
CMGS merged 1 commit into
mainfrom
fix/volcengine-adopt-eni-ids
Sep 3, 2026
Merged

fix: persist adopted Volcengine ENI IDs#17
CMGS merged 1 commit into
mainfrom
fix/volcengine-adopt-eni-ids

Conversation

@CMGS

@CMGS CMGS commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • persist the IDs of Volcengine ENIs that contribute addresses to an adopted pool
  • let teardown retry detached ENIs by exact ID while leaving unrelated secondary ENIs untouched
  • align the pool-state and Volcengine documentation with the new ownership boundary

Why

Without persisted IDs, teardown falls back to listing only ENIs currently attached to the instance. If detach succeeds and delete then fails, the next teardown cannot rediscover that detached ENI and can remove local state while the cloud resource remains.

Verification

  • gofmt -d cmd/adopt.go
  • git diff --check
  • lint, unit tests, and compilation were not run per the static-only review scope

@CMGS
CMGS merged commit ec2e4f6 into main Sep 3, 2026
2 checks passed
@CMGS
CMGS deleted the fix/volcengine-adopt-eni-ids branch September 3, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant