fix: teardown removes the lease file the daemon writes - #19
Closed
CMGS wants to merge 3 commits into
Closed
Conversation
The daemon hardcoded /var/lib/cocoon/net/leases.json while teardown deletes <state-dir>/leases.json, so a custom --state-dir made the daemon persist leases outside the state directory and teardown remove a file nothing wrote. The flag now defaults to empty and resolves to <state-dir>/leases.json at run time; the default installation path is unchanged. Two adjacent output fixes: --primary-nic help claimed auto-detection when the real fallback is platform.DefaultNIC, and adopt --dry-run did not list the ENI IDs it records into pool.json for teardown to delete.
CMGS
changed the title
Contributor
Author
|
Superseded by the rebuilt branch in #20, which sits on the current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teardown deleted
<state-dir>/leases.jsonwhile the daemon persisted leases at its constant default/var/lib/cocoon/net/leases.json, so a custom--state-dirleft the lease file behind. The default stays the constant path, independent of--state-dir(vk-cocoon's reader defaults to the same file), and teardown now removes exactly that file;--lease-filestill overrides the daemon and a custom file is kept on teardown.Also: the
enis:dry-run row, the--lease-fileand lease-path documentation, a restating comment inplatform/ip_test.go, and the reason volcengineAdoptis a no-op.Gates:
make lint0 issues on GOOS=linux and darwin,make fmt-check,asl ./...on both GOOS,go test -race -count=1 ./....