Skip to content

refactor: use &[..] instead of &Vec<..> #8676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
link2xt merged 1 commit into from
Sep 9, 2026
Merged

refactor: use &[..] instead of &Vec<..> #8676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/reaction/broadcast_reactions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ pub(crate) async fn load_broadcast_reactions(
pub(crate) async fn save_broadcast_reactions(
context: &Context,
msg_id: MsgId,
frequencies: &Vec<ReactionFrequency>,
frequencies: &[ReactionFrequency],
) -> Result<()> {
context
.sql
Expand Down
2 changes: 1 addition & 1 deletion src/securejoin/qrinvite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ impl QrInvite {
}
}

pub(crate) fn addrs(&self) -> &Vec<String> {
pub(crate) fn addrs(&self) -> &[String] {
match self {
QrInvite::Contact { addrs, .. } => addrs,
QrInvite::Group { addrs, .. } => addrs,
Expand Down
2 changes: 1 addition & 1 deletion src/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ impl Context {
Ok(())
}

async fn sync_message_deletion(&self, msgs: &Vec<String>) -> Result<()> {

@link2xt link2xt Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy::ptr_arg should catch this case I think, but somehow it does not.

async fn sync_message_deletion(&self, msgs: &[String]) -> Result<()> {
let mut modified_chat_ids = BTreeSet::new();
let mut msg_ids = Vec::new();
for rfc724_mid in msgs {
Expand Down