refactor: use &[..] instead of &Vec<..> - #8676
Merged
Merged
Conversation
Most of such cases are detected by clippy::ptr_arg, but in these cases clippy did not catch anything.
link2xt
added this pull request to stack #8677
September 9, 2026 06:13
link2xt
marked this pull request as ready for review
September 9, 2026 06:14
j-g00da
approved these changes
Sep 9, 2026
link2xt
commented
Sep 9, 2026
| Ok(()) | ||
| } | ||
|
|
||
| async fn sync_message_deletion(&self, msgs: &Vec<String>) -> Result<()> { |
Collaborator
Author
There was a problem hiding this comment.
clippy::ptr_arg should catch this case I think, but somehow it does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of such cases are detected by clippy::ptr_arg, but in these cases clippy did not catch anything.