Fix refresh request consumer invocation for web identity credentials

services/sts/src/main/java/software/amazon/awssdk/services/sts/auth/StsAssumeRoleWithWebIdentityCredentialsProvider.java

@@ -143,10 +143,12 @@ public Builder refreshRequest(Supplier<AssumeRoleWithWebIdentityRequest> assumeR
          * Similar to {@link #refreshRequest(AssumeRoleWithWebIdentityRequest)}, but takes a lambda to configure a new
          * {@link AssumeRoleWithWebIdentityRequest.Builder}. This removes the need to called
          * {@link AssumeRoleWithWebIdentityRequest#builder()} and {@link AssumeRoleWithWebIdentityRequest.Builder#build()}.
+         * The lambda is invoked each time the credentials are refreshed.
          */
         public Builder refreshRequest(Consumer<AssumeRoleWithWebIdentityRequest.Builder> assumeRoleWithWebIdentityRequest) {
-            return refreshRequest(AssumeRoleWithWebIdentityRequest.builder().applyMutation(assumeRoleWithWebIdentityRequest)
-                                                                  .build());
+            return refreshRequest(() ->
+                AssumeRoleWithWebIdentityRequest.builder().applyMutation(assumeRoleWithWebIdentityRequest)
+                                                .build());
         }
 
         /**

services/sts/src/test/java/software/amazon/awssdk/services/sts/auth/StsAssumeRoleWithWebIdentityCredentialsProviderTest.java

@@ -15,6 +15,17 @@
 
 package software.amazon.awssdk.services.sts.auth;
 
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.time.Duration;
+import java.time.Instant;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentCaptor;
 import software.amazon.awssdk.core.useragent.BusinessMetricFeatureId;
 import software.amazon.awssdk.services.sts.StsClient;
 import software.amazon.awssdk.services.sts.auth.StsAssumeRoleWithWebIdentityCredentialsProvider.Builder;
@@ -56,4 +67,35 @@ protected AssumeRoleWithWebIdentityResponse callClient(StsClient client, AssumeR
     protected String providerName() {
         return BusinessMetricFeatureId.CREDENTIALS_STS_ASSUME_ROLE_WEB_ID.value();
     }
+
+    @Test
+    public void refreshRequestConsumerIsInvokedForEachCredentialRefresh() {
+        Credentials credentials = Credentials.builder()
+                                             .accessKeyId("a")
+                                             .secretAccessKey("b")
+                                             .sessionToken("c")
+                                             .expiration(Instant.now().minus(Duration.ofSeconds(5)))
+                                             .build();
+        when(stsClient.assumeRoleWithWebIdentity(any(AssumeRoleWithWebIdentityRequest.class)))
+            .thenReturn(getResponse(credentials));
+
+        AtomicInteger tokenNumber = new AtomicInteger();
+        try (StsAssumeRoleWithWebIdentityCredentialsProvider credentialsProvider =
+                 StsAssumeRoleWithWebIdentityCredentialsProvider.builder()
+                                                               .stsClient(stsClient)
+                                                               .refreshRequest(request ->
+                                                                   request.webIdentityToken("token-" +
+                                                                                            tokenNumber.incrementAndGet()))
+                                                               .build()) {
+            credentialsProvider.resolveCredentials();
+            credentialsProvider.resolveCredentials();
+        }
+
+        ArgumentCaptor<AssumeRoleWithWebIdentityRequest> requestCaptor =
+            ArgumentCaptor.forClass(AssumeRoleWithWebIdentityRequest.class);
+        verify(stsClient, times(2)).assumeRoleWithWebIdentity(requestCaptor.capture());
+        assertThat(requestCaptor.getAllValues())
+            .extracting(AssumeRoleWithWebIdentityRequest::webIdentityToken)
+            .containsExactly("token-1", "token-2");
+    }
 }